-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Mode: Warn about missing defaults for unconfigured settings #43213
Comments
I think, the contribution is happening on the renderer side and not on main side. Hence you see |
Yes, I forgot that contributions are only required from the renderer side. For my specific fix, I split my contributions into two: configuration (down in platform) and others (up in workbench). But it took me way too long to figure this one out. I just wasn't expecting the config service not to have defaults. It would be great to have warnings when accessing unset configuration values, for which no default was ever specified. Renaming the issue. |
One way to do is while accessing the value, check if the requested setting is registered or not. Obviously this should be done only in dev mode to not impact perf. But one problem is that at present, there are quite number of such unregistered settings that components are accessing. Hence, I think it is not worth doing this. |
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding, and happy coding! |
I have this setting
update.enableWindowsBackgroundUpdates
:https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/update/electron-browser/update.contribution.ts#L62
When the user doesn't configure it, reading this value from the configuration service should return the default value. This works from the renderer process. It doesn't from the main process. Instead of getting the default
false
value, I getundefined
.Maybe regression?
The text was updated successfully, but these errors were encountered: