Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux: Main exception on startup, when connecting to running process #43228

Closed
joaomoreno opened this issue Feb 8, 2018 · 3 comments
Closed

Linux: Main exception on startup, when connecting to running process #43228

joaomoreno opened this issue Feb 8, 2018 · 3 comments
Assignees
@bpasero
Labels
candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded
Milestone
January 2018 Reco...

Comments

@joaomoreno
Copy link
Member

Seen on Linux, can't repro on macOS

  1. Start Code oss: ./scripts.code.sh
  2. Start Code oss again on another folder: ./scripts.code.sh FOLDER_NAME

There's an exception popup coming from the main process. Then, the window opens as expected but lots of errors show up:

image

@dbaeumer Assigning to you first, the exception popup happens very early in main and I know you were around that lately.

cc @bpasero @sandy081
@joaomoreno
Copy link
Member Author

joaomoreno commented Feb 8, 2018 •
edited

Nevermind, this was #7950. After raising the file limit, none of this happens.

@bpasero bpasero reopened this Feb 8, 2018
@bpasero bpasero assigned bpasero and unassigned dbaeumer Feb 8, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 8, 2018
@joaomoreno
Copy link
Member Author

Here's the popup:

image

@bpasero bpasero added important Issue identified as high-priority candidate Issue identified as probable candidate for fixing in the next release labels Feb 8, 2018
@joaomoreno
Copy link
Member Author

joaomoreno commented Feb 8, 2018 •
edited

Also reproduces in built insiders.

Steps

  1. Lower the file limit to the default:
    • sudo vim /etc/sysctl.conf
    • At the end, there should be a line with fs.inotify.max_user...; delete it
    • Restart
  2. Open Code in our vscode workspace: code ~/Work/vscode
  3. Open Code again from the terminal, pointing to another folder: code ~/Work/anotherfolder

@bpasero bpasero mentioned this issue Feb 9, 2018
Merged
bpasero added a commit that referenced this issue Feb 12, 2018
@bpasero
address #43228 for insiders
7410a0e
@bpasero bpasero closed this as completed Feb 12, 2018
@Tyriar Tyriar added the verified Verification succeeded label Feb 13, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
January 2018 Recovery
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @dbaeumer @Tyriar