Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Each click into actionbar is delayed by 50ms? #43232

Closed
bpasero opened this issue Feb 8, 2018 · 3 comments
Closed

Each click into actionbar is delayed by 50ms? #43232

bpasero opened this issue Feb 8, 2018 · 3 comments
Assignees
@jrieken
Labels
perf
Milestone
February 2018

Comments

@bpasero
Copy link
Member

bpasero commented Feb 8, 2018 •
edited

It looks like each click to any action in the action bar is delayed by 50ms, coming in from a740256. That means any user interaction in this control is delayed. What is the reason?
@bpasero bpasero added the perf label Feb 8, 2018
@bpasero bpasero changed the title Please no timeout in actionbar on click Please avoid timeout in actionbar on click Feb 8, 2018
@bpasero bpasero assigned jrieken and unassigned alexdima Feb 8, 2018
@bpasero
Copy link
Member Author

bpasero commented Feb 8, 2018

Wait, this came in via a740256. @jrieken whats the reason? If I take the timeout out I see no issue.

@alexdima
Copy link
Member

alexdima commented Feb 8, 2018 •
edited

Yeah, my change removes the timeout for the menu case...

@bpasero bpasero changed the title Please avoid timeout in actionbar on click Each click into actionbar is delayed by 50ms? Feb 8, 2018
@jrieken jrieken added this to the February 2018 milestone Feb 26, 2018
@jrieken
Copy link
Member

jrieken commented Feb 28, 2018

Yeah, no idea why that is... Maybe something that was/is an issue with the animation? I seems to work without but to keep the flow I'll change to setImmediate first

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
perf
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@bpasero @jrieken @alexdima