Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileEditorInput: Holds on to all inputs that got created until file is deleted #4364

Closed
bpasero opened this issue Mar 17, 2016 · 2 comments
Closed

FileEditorInput: Holds on to all inputs that got created until file is deleted #4364

bpasero opened this issue Mar 17, 2016 · 2 comments
Assignees
@bpasero
Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s)
Milestone
Backlog

Comments

@bpasero
Copy link
Member

bpasero commented Mar 17, 2016

Somehow FILE_EDITOR_MODEL_CLIENTS keeps some clients although switching between files should dispose their associated inputs and clients too.
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Mar 17, 2016
@bpasero bpasero self-assigned this Mar 17, 2016
@bpasero bpasero modified the milestones: March 2016, April 2016 Mar 17, 2016
@bpasero
Copy link
Member Author

bpasero commented Mar 17, 2016

Too risky to touch this guy for GA imho.

@bpasero bpasero added the debt Code quality issues label Mar 29, 2016
@bpasero bpasero changed the title Leak: FILE_EDITOR_MODEL_CLIENTS does not reduce when switching between files FileEditorInput: Holds on to all inputs that got created until file is deleted Mar 30, 2016
@bpasero bpasero modified the milestones: Backlog, April 2016 Mar 30, 2016
@bpasero bpasero removed the bug Issue identified by VS Code Team member as probable bug label Apr 5, 2016
@bpasero bpasero modified the milestones: Backlog, June 2016 May 19, 2016
@bpasero bpasero modified the milestones: Backlog, June 2016 Jun 3, 2016
@bpasero
Copy link
Member Author

bpasero commented Jun 3, 2016

#6519

@bpasero bpasero closed this as completed Jun 3, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Jun 3, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@bpasero