Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onDidStartDebugSession can fire without onDidTerminateDebugSession firing later #43752

Closed
DanTup opened this issue Feb 15, 2018 · 3 comments
Closed

onDidStartDebugSession can fire without onDidTerminateDebugSession firing later #43752

DanTup opened this issue Feb 15, 2018 · 3 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
February 2018

Comments

@DanTup
Copy link
Contributor

DanTup commented Feb 15, 2018

I think this may be deliberate (#29666) but it feels wonky.

I have a class that subscribes to onDidStartDebugSession and also onDidTerminateDebugSession. If a debug session fails to start, the first is called but the second is not. This means if I set something up (like a status bar, progress indicator, whatever) it gets left around if the debugger didn't start.

It feels like I shouldn't need to start leaking code out elsewhere to try and tidy this up, it feels like these two commands should go together (or at least, we should have some similar event we can rely on to fire when a debugging session ends for whatever reason).
@weinand weinand assigned isidorn and unassigned weinand Feb 15, 2018
@weinand weinand added this to the February 2018 milestone Feb 15, 2018
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Feb 15, 2018
DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Feb 15, 2018
@DanTup
Add commented out code to handle debug progress
12a3da6 
See #571.
Awaiting a response to microsoft/vscode#43752.
@DanTup DanTup mentioned this issue Feb 15, 2018
Closed
@isidorn
Copy link
Contributor

isidorn commented Feb 15, 2018

Makes sense to me. Try it out in tomorrows insiders and let us know how it goes
@roblourens fyi

DanTup added a commit to Dart-Code/Dart-Code that referenced this issue Feb 15, 2018
@DanTup
Add commented out code to handle debug progress
65a2b89 
See #571.
Awaiting a response to microsoft/vscode#43752.
@DanTup
Copy link
Contributor Author

DanTup commented Feb 20, 2018

LGTM in insiders 👍

@DanTup DanTup mentioned this issue Feb 20, 2018
Closed
@isidorn isidorn added the verified Verification succeeded label Feb 20, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2018

@DanTup thanks, adding verified label

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@DanTup @weinand @isidorn