-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[theming] Make contrastActiveBorder around text optional/themeable #43761
Comments
I added a new color id 'editor.rangeHighlightBorder' that controls the border color you mention. |
The name seems suboptimal as it sounds similar to editor.findRangeHighlightBackground and would suggest it only affects the same text. We're talking about at least 3 things here whose background colors are editor.findMatchBackground, editor.findMatchHighlightBackground and editor.findRangeHighlightBackground. |
Just to make sure we're on the same page. Aside from the findRange... there are other occurrences, such as peekViewResult.* |
Good point, there are more uses of Agree that |
The border around the identifier name in "Peek Definition" is still not themeable. Other than that things look good. I can activate contrastActiveBorder in my theme now without getting eye cancer. Thank you very much. |
I like contrastActiveBorder and think it is very useful around UI elements such as buttons, list elements, active tabs etc.
However around text in the editor I think it is extremely counterproductive. It makes things harder to read. I find the borders around text so unbearable that I set contrastActiveBorder to transparent because I would rather lose all the benefits than deal with this (after all, I stare at text all day). It would be way more useful to expand the selectionForeground feature to more parts, so that e.g. Find locations (such as the one in the screenshot below) could be made more visible that way. A more general approach that would not require themeing would be to either invert the colors or swap background/foreground similar to what terminals do.
Anyway, until a better solution is implemented I would like to see an independent "contrastActiveTextBorder" color that is used around editor text. It can fall back to contrastActiveBorder so that backwards compatibility would be maintained (for whatever weird person finds this useful), but themes could independently set it to transparent to make it disappear while keeping the contrastActiveBorder around UI elements.
The text was updated successfully, but these errors were encountered: