Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webview: Use actual editor changes for onBecameActive/onBecameInactive #43775

Closed
mjbvz opened this issue Feb 15, 2018 · 1 comment
Closed

Webview: Use actual editor changes for onBecameActive/onBecameInactive #43775

mjbvz opened this issue Feb 15, 2018 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
February 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 15, 2018 •
edited

Bug
Currently the new webview API uses the Webview.onFocus and Webview.onBlur event for onBecameActive and onBecameInactive. This results in a lot of false switches when the webview element itself loses focus, such as when switching away from the vscode window

Fix
Use actual editor change events for these instead
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 15, 2018
@mjbvz mjbvz added this to the February 2018 milestone Feb 15, 2018
@mjbvz mjbvz self-assigned this Feb 15, 2018
@mjbvz mjbvz closed this as completed in 70b41f0 Feb 15, 2018
@mjbvz mjbvz added the verified Verification succeeded label Mar 1, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 1, 2018

Code only change. Testing of this was covered by tests for the new markdown preview

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
1 participant
@mjbvz