Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background updater needs to beware if windows is going to sleep/shutdown #43971

Closed
pellea opened this issue Feb 19, 2018 · 8 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@pellea
Copy link

pellea commented Feb 19, 2018

  • VSCode Version: Insider
  • OS Version: Win 10

Steps to Reproduce:

  1. check for updates (and totally forget you did it ...)
  2. put the computer to sleep several times with VSCode still running (maybe not related)
  3. close VSCode
  4. restart the computer

After the restart, I had no VSCode installed. I had to reinstall it completely.

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Feb 19, 2018
@joaomoreno
Copy link
Member

@pellea Was the C:\Program Files\Microsoft VS Code Insiders folder completely gone?

@pellea
Copy link
Author

pellea commented Feb 19, 2018

@joaomoreno I don't know. I pinned VSCode to the taskbar and when I clicked on the shortcut; it was invalid.

@joaomoreno
Copy link
Member

OK. If it happens again, let me know.

@pellea
Copy link
Author

pellea commented Feb 22, 2018

It happened again (though I forced it a little bit).

Here are the only remaining files in the VSCode folder:

resources
tools
_
snapshot_blob.bin
ucrtbase.dll
ui_resources_200_percent.pak
unins000.dat
unins000.exe
vcruntime140.dll
views_resources_200_percent.pak

@joaomoreno
Copy link
Member

How did you force it a little bit?

@joaomoreno joaomoreno reopened this Feb 22, 2018
@pellea
Copy link
Author

pellea commented Feb 22, 2018

I restarted my computer quickly after having closed vscode.

There is the screen where Windows tells us a process is blocking the restart but it has still restarted without delay and without giving me the possibility to cancel the restart.

@joaomoreno joaomoreno changed the title Failed to update VSCode insider correctly Background updater needs to beware if windows is going to sleep/shutdown Feb 22, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues windows VS Code on Windows issues and removed info-needed Issue requires more information from poster labels Feb 22, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, February 2018 Feb 22, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Feb 23, 2018

@pellea Awesome that you test this so nicely! I've pushed some changes which should prevent Windows from forcefully shutting down our updater tool:

microsoft/inno-updater@143ec7d...bfbe044

Please give it another spin next week (next build is Monday morning, CET) and let me know if you can still get into that state.

@mjbvz mjbvz added the verified Verification succeeded label Mar 2, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Mar 2, 2018

Verified that windows now warns you if you try to shut down while the installer is running

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

3 participants