-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Background updater needs to beware if windows is going to sleep/shutdown #43971
Comments
@pellea Was the |
@joaomoreno I don't know. I pinned VSCode to the taskbar and when I clicked on the shortcut; it was invalid. |
OK. If it happens again, let me know. |
It happened again (though I forced it a little bit). Here are the only remaining files in the VSCode folder:
|
How did you force it a little bit? |
I restarted my computer quickly after having closed vscode. There is the screen where Windows tells us a process is blocking the restart but it has still restarted without delay and without giving me the possibility to cancel the restart. |
@pellea Awesome that you test this so nicely! I've pushed some changes which should prevent Windows from forcefully shutting down our updater tool: microsoft/inno-updater@143ec7d...bfbe044 Please give it another spin next week (next build is Monday morning, CET) and let me know if you can still get into that state. |
Verified that windows now warns you if you try to shut down while the installer is running |
Steps to Reproduce:
After the restart, I had no VSCode installed. I had to reinstall it completely.
The text was updated successfully, but these errors were encountered: