Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search: dismissing a search result should move to next result #43976

Closed
bpasero opened this issue Feb 19, 2018 · 3 comments
Closed

Search: dismissing a search result should move to next result #43976

bpasero opened this issue Feb 19, 2018 · 3 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
April 2018

Comments

@bpasero
Copy link
Member

bpasero commented Feb 19, 2018

Steps to Reproduce:

  1. have search results
  2. dismiss the last search result of a file
  3. the next file is selected

=> it would be great if the search result within that next file is selected instead
@roblourens roblourens added feature-request Request for new features or functionality search Search widget and operation issues labels Mar 6, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Apr 23, 2018
@roblourens roblourens added this to the April 2018 milestone Apr 23, 2018
@bpasero
Copy link
Member Author

bpasero commented Apr 25, 2018

@roblourens still reproduces I think:
flicker_chrome58

@bpasero bpasero reopened this Apr 25, 2018
@bpasero bpasero added the verification-found Issue verification failed label Apr 25, 2018
@roblourens
Copy link
Member

That's not the case I was looking at, but I can fix that too.

@bpasero bpasero added verified Verification succeeded and removed verification-found Issue verification failed labels Apr 26, 2018
@bpasero
Copy link
Member Author

bpasero commented Apr 26, 2018

Better, I filed #48740 as follow up 👍

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@roblourens @bpasero