Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os.homedir() is only supported in node >= 4 #4404

Closed
bpasero opened this issue Mar 18, 2016 · 3 comments
Closed

os.homedir() is only supported in node >= 4 #4404

bpasero opened this issue Mar 18, 2016 · 3 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded

Comments

@bpasero
Copy link
Member

bpasero commented Mar 18, 2016

@Tyriar please fix, I pushed a workaround here: faffb7d

I think we should still allow to build on older node.js versions unless there is a major reason otherwise.
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Mar 18, 2016
@Tyriar
Copy link
Member

Tyriar commented Mar 18, 2016

@joaomoreno how exactly was the windows build breaking in 3a3c9e1? Doesn't the process.env['HOME'] only get evaluated if the task is called in to? It feels weird to do process.env[(process.platform == 'win32') ? 'USERPROFILE' : 'HOME'] here when it should never be run on Windows.

@Tyriar
Copy link
Member

Tyriar commented Mar 18, 2016

@joaomoreno oh I think I got it; because we create the gulp task by calling prepareRpmPackage, I'll fix it up.

@Tyriar Tyriar closed this as completed in c09bd4b Mar 18, 2016
@joaomoreno
Copy link
Member

👎 0.12 is not even LTS now. We should stop supporting it.

@bpasero bpasero added the verified Verification succeeded label Jul 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @Tyriar