Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use 'panel' for split views in UX #44044

Closed
isidorn opened this issue Feb 20, 2018 · 1 comment
Closed

Do not use 'panel' for split views in UX #44044

isidorn opened this issue Feb 20, 2018 · 1 comment
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
February 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2018

The word panel is already taken in our UX for the bottom workbench panel.
Please do not steal this term for the split view views.
Yes I understand it is named like that in our code base, which is fine for it to be confusing for our team members, but we should not make it more confusing for the users.

screen shot 2018-02-20 at 16 04 40
@joaomoreno joaomoreno removed their assignment Feb 20, 2018
@sandy081 sandy081 assigned joaomoreno and unassigned sandy081 Feb 20, 2018
@sandy081
Copy link
Member

@joaomoreno This action came from the PR fixing this issue #37714.

@joaomoreno joaomoreno added this to the February 2018 milestone Feb 21, 2018
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Feb 21, 2018
@joaomoreno joaomoreno mentioned this issue Feb 21, 2018
Merged
@isidorn isidorn added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@joaomoreno @isidorn @sandy081