Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown links not syntax colored #44058

Closed
smlombardi opened this issue Feb 20, 2018 · 2 comments
Closed

Markdown links not syntax colored #44058

smlombardi opened this issue Feb 20, 2018 · 2 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-found Issue verification failed verified Verification succeeded
Milestone
February 2018

Comments

@smlombardi
Copy link

Issue Type

Bug

Description

Using a sentence like

It is worth reviewing the [entire migration page](https://getbootstrap.com/docs/4.0/migration/) on the Boostrap 4 web site.

The linked text and the link itself are no longer syntax colored. They used to be.

Inspecting the scope shows both items are only scoped to meta.paragraph.markdown.

This is the same if the links are in bullet text, then they are scoped markup.list meta.paragraph.markdown like the surrounding text.

VS Code Info

VS Code version: Code - Insiders 1.21.0-insider (6309a77, 2018-02-20T10:16:08.796Z)
OS version: Darwin x64 17.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.66GB free)
Process Argv /Users/st016lo/Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_1343816
Screen Reader no
VM 0%
Extensions (26)
Extension Author (truncated) Version
vsc-material-theme Equ 1.4.2
code-settings-sync Sha 2.8.7
sort-lines Tyr 1.4.1
html-snippets abu 0.2.1
Bookmarks ale 0.18.1
project-manager ale 0.24.0
vscode-eslint dba 1.4.6
tslint eg2 1.0.28
prettier-vscode esb 1.1.3
vscode-console-wrapper fab 0.4.0
auto-rename-tag for 0.0.15
path-autocomplete ion 1.8.1
vscode-text-pastry jkj 1.2.0
svg joc 0.0.9
Angular2 joh 2.13.0
vscode-icon-theme jtl 1.6.1
ecdc mit 0.11.0
HTMLHint mka 0.4.0
vscode-scss mrm 0.6.2
vscode-stylefmt mrm 2.5.0
angular2-inline nat 0.0.17
polacode pnp 0.2.2
stylelint shi 0.32.0
Align ste 0.2.0
bootstrap4-vscode the 4.0.0
change-case wma 1.0.0

(2 theme extensions excluded)

Reproduces only with extensions
@vscodebot vscodebot bot added the markdown Markdown support issues label Feb 20, 2018
@mjbvz mjbvz mentioned this issue Feb 20, 2018
Closed
@mjbvz
Copy link
Contributor

mjbvz commented Feb 20, 2018

This issue was moved to microsoft/vscode-markdown-tm-grammar#10

@mjbvz mjbvz closed this as completed Feb 20, 2018
@mjbvz mjbvz added this to the February 2018 milestone Feb 20, 2018
@mjbvz mjbvz added upstream Issue identified as 'upstream' component related (exists outside of VS Code) grammar Syntax highlighting grammar bug Issue identified by VS Code Team member as probable bug labels Feb 20, 2018
@jrieken jrieken reopened this Mar 1, 2018
@jrieken jrieken added the verification-found Issue verification failed label Mar 1, 2018
@jrieken
Copy link
Member

jrieken commented Mar 1, 2018

screen shot 2018-03-01 at 13 51 37

@mjbvz mjbvz closed this as completed in cbbdc2d Mar 1, 2018
@jrieken jrieken added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug grammar Syntax highlighting grammar markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@smlombardi @jrieken @mjbvz