Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when multiple grammars are contributed for the same scope. #44095

Closed
aeschli opened this issue Feb 21, 2018 · 1 comment
Closed

Warn when multiple grammars are contributed for the same scope. #44095

aeschli opened this issue Feb 21, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 21, 2018

Both SQL and Visual Studio Code Tools for AI provide a grammar for the same scope (but different language ids).
This leads to the sql grammar being replaced which is hard to detect.
We should warn when that happens.

@alexdima
Copy link
Member

To reproduce:

  • package.json:
{
	"publisher": "alex",
	"name": "44095",
	"version": "0.0.0",
	"engines": {
		"vscode": "^1.0.0"
	},
	"contributes": {
		"languages": [
			{
				"id": "cntk",
				"aliases": [
					"CNTK",
					"cntk"
				],
				"extensions": [
					".cntk",
					".bs"
				],
				"configuration": "./cntk.configuration.json"
			}
		],
		"grammars": [
			{
				"language": "cntk",
				"scopeName": "source.sql",
				"path": "./syntaxes/cntk.tmLanguage"
			}
		]
	}
}

@alexdima alexdima added this to the February 2018 milestone Feb 23, 2018
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2018
@aeschli aeschli added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants