Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable all extensions also disables built-in extensions #44104

Closed
aeschli opened this issue Feb 21, 2018 · 5 comments
Closed

Disable all extensions also disables built-in extensions #44104

aeschli opened this issue Feb 21, 2018 · 5 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verification-found Issue verification failed verified Verification succeeded
Milestone
February 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 21, 2018

Version 1.21.0-insider
Commit 6309a77
Date 2018-02-20T10:23:21.993Z

  • from the extensions viewlet drop down select 'Disable All Installed Extension'
  • restart
  • note that also all built-in extensions are disabled
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions labels Feb 21, 2018
@sandy081 sandy081 added this to the February 2018 milestone Feb 21, 2018
@aeschli aeschli added the verified Verification succeeded label Mar 1, 2018
@sbatten sbatten added verification-found Issue verification failed and removed verified Verification succeeded labels Mar 5, 2018
@sbatten
Copy link
Member

sbatten commented Mar 5, 2018

Reloading windows with disabled extensions now puts builtin extensions in a perpetual "reload to deactivate" state.
image

@sbatten sbatten reopened this Mar 5, 2018
@sandy081
Copy link
Member

sandy081 commented Mar 5, 2018

@sbatten What are the steps you followed to get into this state?

@sbatten
Copy link
Member

sbatten commented Mar 5, 2018

@sandy081

  1. Open insiders and show built in extensions to see everything is normal.
  2. Use command palette to reload window with extensions disabled.
  3. Show builtin extensions. All will be enabled but have 'reload' buttons with hover text 'reload to deactivate'

@RMacfarlane
Copy link
Contributor

The Reload Window with Extensions Disabled action uses the same switch as the --disable-extensions flag, so this can also be repro'ed just by lauching code-insiders with --disable-extensions.

sandy081 added a commit that referenced this issue Mar 6, 2018
@sandy081
Fix #44104
1035348
@sandy081
Copy link
Member

sandy081 commented Mar 6, 2018 •
edited

@sbatten Good catch. Provided a minimal fix - not to show reload action when code started with --disable-extensions. This fix is pushed only to 1.21 release branch.

Implementation wise, it is not ideal. Created a follow up debt item for cleaner implementation -#45122

@sandy081 sandy081 closed this as completed Mar 6, 2018
@aeschli aeschli added the verified Verification succeeded label Mar 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
4 participants
@RMacfarlane @aeschli @sbatten @sandy081