Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List: aria-posinset and aria-setsize are wrong in this case #44177

Closed
bpasero opened this issue Feb 22, 2018 · 2 comments
Closed

List: aria-posinset and aria-setsize are wrong in this case #44177

bpasero opened this issue Feb 22, 2018 · 2 comments
Assignees
@joaomoreno @isidorn
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug list-widget List widget issues verified Verification succeeded workbench-notifications Notification widget issues
Milestone
February 2018

Comments

@bpasero
Copy link
Member

bpasero commented Feb 22, 2018 •
edited

Steps to Reproduce:

  1. have a HTML file to trigger notifications like the one below
  2. follow one link to get an error that the file does not exist and now open notifications center to get a list view
  3. continue with other links until you get 3-4 errors

=> check the aria-posinset and aria-setsize property having weird values

image

<!DOCTYPE html>
<html>

<head>
	<title>Mankala</title>
    <meta http-equiv="X-UA-Compatible" content="IE=Edge"/>
    <script type="text/javascript" src="Game2.js"></script>
  	<script type="text/javascript" src="Driver2.js"></script>
	<script type="text/javascript" src="Features2.js"></script>
	<script type="text/javascript" src="Position.js"></script>
	<script type="text/javascript" src="lib/Geometry.js"></script>
	<script type="text/javascript" src="lib/Base.js"></script>
</head>

<body id="bod" onload="Mankala.testBrowser()">
   <svg height="10px">
     <defs>
       <radialGradient id="grad1" cx="50%" cy="50%" r="50%" fx="50%" fy="50%">
         <stop offset="0%" style="stop-color:aqua;
                                  stop-opacity:0.35" />
         <stop offset="100%" style="stop-color:rgb(0,0,255);stop-opacity:1" />
       </radialGradient>
       <radialGradient id="grad2" cx="50%" cy="50%" r="50%" fx="50%" fy="50%">
         <stop offset="0%" style="stop-color:gold;
                                  stop-opacity:0.35" />
         <stop offset="100%" style="stop-color:rgb(0,255,0);stop-opacity:1" />
       </radialGradient>
     </defs>
   </svg>
</body>
</html>
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues workbench-notifications Notification widget issues list-widget List widget issues labels Feb 22, 2018
@joaomoreno joaomoreno added this to the February 2018 milestone Feb 22, 2018
@joaomoreno
Copy link
Member

Yeah, this doesn't work. We need to move aria down to the ListView.

@bpasero
Copy link
Member Author

bpasero commented Feb 22, 2018

@joaomoreno thanks!

@bpasero bpasero added the verified Verification succeeded label Feb 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@isidorn isidorn

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug list-widget List widget issues verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @isidorn