Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot select text from notifications. #44301

Closed
drproteus opened this issue Feb 23, 2018 · 3 comments
Closed

Cannot select text from notifications. #44301

drproteus opened this issue Feb 23, 2018 · 3 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded workbench-notifications Notification widget issues
Milestone
February 2018

Comments

@drproteus
Copy link

  • VSCode Version: 1.21.0-insider (1.21.0-insider)
  • OS Version: macOS 10.12.6 (16G1212)

Steps to Reproduce:

  1. Get a notification
  2. Try to select text from the body
    Result: You cannot.

I switched to the insiders build to solve the command palette Revert File issue, and now I found I can't copy-paste PR # or commit hash from the Git blame notification as before.

Does this issue occur when all extensions are disabled?: Yes/No
@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Feb 23, 2018
@RMacfarlane RMacfarlane added workbench-notifications Notification widget issues and removed editor editor-contrib Editor collection of extras labels Feb 23, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 24, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 24, 2018
@bpasero
Copy link
Member

bpasero commented Feb 26, 2018

I pushed a change to allow for text selection as well as a "Copy Text" action when you right click on a notification.

@jrieken jrieken reopened this Mar 1, 2018
@jrieken jrieken added verification-found Issue verification failed verified Verification succeeded labels Mar 1, 2018
@jrieken
Copy link
Member

jrieken commented Mar 1, 2018 •
edited

Selecting only works for me when the notification is expanded

mar-01-2018 11-32-01

@bpasero
Copy link
Member

bpasero commented Mar 1, 2018

I pushed a fix so that any message text can be selected.

@bpasero bpasero closed this as completed Mar 1, 2018
bpasero added a commit that referenced this issue Mar 1, 2018
@bpasero
fix #44301
415c463
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verification-found Issue verification failed verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
4 participants
@bpasero @jrieken @RMacfarlane @drproteus