Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emmet regression - css - opacity: 0.5 not working in 1.21 #44352

Closed
user3323 opened this issue Feb 25, 2018 · 1 comment · Fixed by #44781
Closed

Emmet regression - css - opacity: 0.5 not working in 1.21 #44352

user3323 opened this issue Feb 25, 2018 · 1 comment · Fixed by #44781
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Milestone
February 2018

Comments

@user3323
Copy link

user3323 commented Feb 25, 2018 •
edited

  • VSCode Version: 1.21.0-ins
  • OS Version: win7x64

op0.5 - should be expanded into opacity: 0.5, right?

so as op.5

op0 5

PS:
in the stable version...

Version 1.20.1
Commit f88bbf9137d24d36d968ea6b2911786bfe103002
Date 2018-02-13T15:34:36.336Z

... it works fine.

So, the problem is in Insiders build.

Version 1.21.0-insider
Commit ce13bb0dabd06981913c46b5a94456647864c2e0
Date 2018-02-23T05:19:18.064Z
@vscodebot vscodebot bot added the emmet Emmet related issues label Feb 25, 2018
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Feb 26, 2018 •
edited

Root cause: microsoft/vscode-css-languageservice#69

@user3323 In the Insiders, we have moved to using the same parser as the css extension does. Thus the slight changes in Insiders vs Stable.

You along with a few other Emmet users in Insiders, in this past year, have been a great asset to us in finding Emmet bugs that resulted in us improving the Emmet experience. If you find any other discrepancies, please feel free to file issues.

@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Feb 26, 2018
@ramya-rao-a ramya-rao-a added this to the February 2018 milestone Feb 26, 2018
ramya-rao-a added a commit that referenced this issue Mar 1, 2018
@ramya-rao-a
Allow css emmet completions when abbr contains period Fixes #44352
562e63a
@ramya-rao-a ramya-rao-a mentioned this issue Mar 1, 2018
Merged
@ramya-rao-a ramya-rao-a changed the title Emmet - css - opacity: 0.5 Emmet regression - css - opacity: 0.5 not working in 1.21 Mar 1, 2018
ramya-rao-a added a commit that referenced this issue Mar 1, 2018
@ramya-rao-a
Allow css emmet completions when abbr contains period Fixes #44352
d6f9cb0
ramya-rao-a added a commit that referenced this issue Mar 1, 2018
@ramya-rao-a
Move css related workaround to cssMode #44352
788d963
ramya-rao-a added a commit that referenced this issue Mar 1, 2018
@ramya-rao-a
Allow css emmet completions when abbr contains period Fixes #44352
e88bf32
ramya-rao-a added a commit that referenced this issue Mar 1, 2018
@ramya-rao-a
Move css related workaround to cssMode #44352
47651db
ramya-rao-a added a commit that referenced this issue Mar 2, 2018
@ramya-rao-a
Allow css emmet completions when abbr contains period Fixes #44352 (#…
d7dca14 
…44781)

* Allow css emmet completions when abbr contains period Fixes #44352

* Move css related workaround to cssMode #44352

* getEmbeddedParsedDocument is now not needed

* Show emmet completions everywhere inside the embedded css doc
@tsalinger tsalinger added the verified Verification succeeded label Mar 2, 2018
@ramya-rao-a ramya-rao-a mentioned this issue Mar 5, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
3 participants
@tsalinger @ramya-rao-a @user3323