Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle disabling of the default theme extension #44510

Closed
bpasero opened this issue Feb 27, 2018 · 3 comments
Closed

Handle disabling of the default theme extension #44510

bpasero opened this issue Feb 27, 2018 · 3 comments
Assignees
@aeschli @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions themes Color theme issues verified Verification succeeded
Milestone
February 2018

Comments

@bpasero
Copy link
Member

bpasero commented Feb 27, 2018 •
edited by sandy081

Testing #44361

  • Have any default theme as active theme
  • Disable the default theme extension
  • reload

=> the theme is still active

We should maybe be careful with allowing to disable our built in default themes. @aeschli could maybe comment on that
@sandy081
Copy link
Member

I think this is only happening for default themes extension, others are behaving similar to market place extensions.

@aeschli What is expected when a default themes extension is disabled when it is active?

@sandy081 sandy081 added themes Color theme issues extensions Issues concerning extensions labels Feb 27, 2018
@sandy081 sandy081 changed the title Disabling a build in theme does not unset it Disabling a build in default theme does not unset it Feb 27, 2018
@aeschli
Copy link
Contributor

aeschli commented Feb 27, 2018

We currently expect the default themes to be present as they are the fallback.

@aeschli aeschli changed the title Disabling a build in default theme does not unset it Handle disabling of the default theme extension Feb 28, 2018
@sandy081 sandy081 modified the milestones: March 2018, February 2018 Feb 28, 2018
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2018
@aeschli
Copy link
Contributor

aeschli commented Mar 1, 2018

The fix makes sure that the default theme ('Default Dark+') is always available. If the extension is not present, a dummy is created, without syntax colors.

@Tyriar Tyriar added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions themes Color theme issues verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
4 participants
@bpasero @Tyriar @aeschli @sandy081