Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad ux flow for pinning markdown preview #44529

Closed
isidorn opened this issue Feb 27, 2018 · 3 comments
Closed

Bad ux flow for pinning markdown preview #44529

isidorn opened this issue Feb 27, 2018 · 3 comments
Assignees
@mjbvz
Labels
markdown Markdown support issues
Milestone
February 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2018

Refs: #44462

Currently there are two commands:

  • Markdown: Open Preview
  • Markdown: Open Pinned Preview to the Side

These should not be two commands, but just one and the user should be able to pin the preview after the fact. How can he know if he wants to preview before he actually sees it.

I suggest the following:

  • Remove Markdown: Open Pinned Preview to the Side
  • Add a Pin Preview command in the elipses of the editor title area, beneath the "Refresh Preview"
@isidorn isidorn added the markdown Markdown support issues label Feb 27, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Feb 27, 2018 •
edited

Actually I think the name pinned is even incorrect. We already use the pinning term in the workbench and we render unpinned file names in italic. I would not overload the term by making it mean something else. I think the term lock is a good alternative. You can even use a lock icon for the metaphor.

@mjbvz Have you thought about a little header or footer bar inside each markdown preview view, in which you could render a checkbox which would control this behaviour?

@isidorn
Copy link
Contributor Author

isidorn commented Feb 27, 2018

Agree that pinned is a bad name since already taken.
Lock is good. Maybe also "track", by default it tracks, and you can disable that with a checkbox / action

@mjbvz mjbvz added this to the February 2018 milestone Feb 27, 2018
mjbvz added a commit that referenced this issue Feb 28, 2018
@mjbvz
Rename markdown pinned preview to locked preview
8fff87b 
#44529
@mjbvz mjbvz closed this as completed in 7d8c3bb Feb 28, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Feb 28, 2018

Change the term to "locked" and added a command to toggle locking on a preview.

Not sure we can render a lock icon in the title currently (besides using an emoji). Current approach marks locked previews as [Preview]. Let me know if you have any suggestions for how to make more clear

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
markdown Markdown support issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@joaomoreno @isidorn @mjbvz