Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected launch.config search order #44553

Closed
weinand opened this issue Feb 27, 2018 · 1 comment
Closed

Unexpected launch.config search order #44553

weinand opened this issue Feb 27, 2018 · 1 comment
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach

Comments

@weinand
Copy link
Contributor

weinand commented Feb 27, 2018

Testing #44449:

I have this launch config in 3 location: folder, workspace, user:

{
		"type": "node",
		"request": "launch",
		"name": "Workspace Launch",
		"program": "${workspaceFolder}/hello.js"
}

2018-02-27_12-39-00

If I press F5, my hello.js starts but the launch config is always taken from the user settings (despite the fact that there is both a local and a workspace one).
I would expect that the launch configs are searched in the order: folder -> workspace -> user.

If I remove the launch config from the user settings and press F5, the launch config from the folder is used.
So the current search order is: user -> folder -> workspace.
This is a bit unnatural and unexpected.

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach labels Feb 27, 2018
@weinand weinand changed the title F5 Unexpected launch.config search order Feb 27, 2018
@weinand
Copy link
Contributor Author

weinand commented Feb 27, 2018

Ohh I see that there is no search order. The currently selected launch config is used.
And in the initial case - when there is no selection - the first item is picked automatically.

So we will just have to make sure that the order of items in the dropdown is:
folder launches, workspaces launches, and user launches.

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants