Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly indicate "extension" within source #44583

Closed
Tyriar opened this issue Feb 27, 2018 · 0 comments
Closed

Explicitly indicate "extension" within source #44583

Tyriar opened this issue Feb 27, 2018 · 0 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Milestone
February 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2018

#44319

It looks like an extension's displayName is used, this could hurt us in the long run:

image

I'd prefer "Source: Integrated Terminal (Extension)"
@Tyriar Tyriar added the workbench-notifications Notification widget issues label Feb 27, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 27, 2018
@bpasero bpasero closed this as completed Feb 27, 2018
bpasero added a commit that referenced this issue Feb 27, 2018
@bpasero
fix #44583
2600930
@Tyriar Tyriar added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
2 participants
@bpasero @Tyriar