Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A 1 is indicated in notification center when I expect 2 #44588

Closed
Tyriar opened this issue Feb 27, 2018 · 2 comments
Closed

A 1 is indicated in notification center when I expect 2 #44588

Tyriar opened this issue Feb 27, 2018 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Milestone
February 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 27, 2018

VS Code version: Code - Insiders 1.21.0-insider (1a84a88, 2018-02-27T06:17:53.785Z)
OS version: Linux x64 4.13.0-36-generic

#44319

Repro:

Launch an extension with the following:

let disposable = vscode.commands.registerCommand('extension.sayHello', () => {
    vscode.window.showErrorMessage('one', 'a', 'b');
    vscode.window.showWarningMessage('two', 'c', 'd');
});

Run the command:

image

Click notification center and press esc to dismiss.

image

Run the command again, there's a 1 not a 2 next to the bell:

image
@Tyriar Tyriar added the workbench-notifications Notification widget issues label Feb 27, 2018
@vscodebot vscodebot bot added the insiders label Feb 27, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Feb 27, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 27, 2018
@bpasero
Copy link
Member

bpasero commented Feb 27, 2018

The issue here was that notifications that replace an existing one would count as new, which is wrong. I am now not incrementing the counter if a notification appears again that was already showing in the notifications center.

bpasero added a commit that referenced this issue Feb 28, 2018
@bpasero
better fix for #44588
2469920
@bpasero
Copy link
Member

bpasero commented Feb 28, 2018

I pushed a better fix, so that the counter shows up as 2 when the notifications come in again even if they were already there.

@tsalinger tsalinger added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@bpasero @Tyriar @tsalinger