Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot add keyboard shortcuts from the UI #44661

Closed
sbatten opened this issue Feb 27, 2018 · 2 comments
Closed

Cannot add keyboard shortcuts from the UI #44661

sbatten opened this issue Feb 27, 2018 · 2 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
February 2018

Comments

@sbatten
Copy link
Member

sbatten commented Feb 27, 2018 •
edited by sandy081

Issue Type: Bug

  1. From settings gear, open keybindings.
  2. Select a command which does not have keybinding and click the plus (+) icon.
  3. Enter a keystroke and press enter.
  4. Receive the following error notification.
    Cannot read property 'getUserSettingsLabel' of null

VS Code version: Code - Insiders 1.21.0-insider (1a84a88, 2018-02-27T09:01:48.555Z)
OS version: Windows_NT x64 10.0.16299

Reproduces without extensions
@sbatten sbatten added the important Issue identified as high-priority label Feb 27, 2018
@sbatten sbatten added this to the February 2018 milestone Feb 27, 2018
@vscodebot vscodebot bot added the insiders label Feb 27, 2018
@sbatten
Copy link
Member Author

sbatten commented Feb 27, 2018

As a clarification, existing keybindings can be changed from the UI.

@ethanmoffat
Copy link

I'm seeing the same error. Code version:

Version 1.21.0-insider
Commit 1a84a88
Date 2018-02-27T09:01:48.555Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

This is a fresh install with no extensions.

@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2018
@bpasero bpasero added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
5 participants
@roblourens @bpasero @sbatten @ethanmoffat @sandy081