Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal: Add button acts on terminal group but Delete button acts on each terminal #44667

Closed
ramya-rao-a opened this issue Feb 27, 2018 · 2 comments
Closed

Terminal: Add button acts on terminal group but Delete button acts on each terminal #44667

ramya-rao-a opened this issue Feb 27, 2018 · 2 comments
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues

Comments

@ramya-rao-a
Copy link
Contributor

Testing #44446

  • The plus action on the panel adds new terminal group
  • Alt+Plus button on the panel splits the terminal i.e adds to current group
  • Delete button deletes current terminal in the current group

The context on these 2 buttons should be consistent
Either both act on the group and the alt acts on individual terminals or the other way around
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Feb 27, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2018

I'm going to move split to the left of the bin icon to help with this, will need some feedback from UX on this though.

@Tyriar Tyriar added ux User experience issues under-discussion Issue is under discussion for relevance, priority, approach labels Feb 28, 2018
Tyriar added a commit that referenced this issue Feb 28, 2018
@Tyriar
Move the split terminal button to the left of the bin
f1434f7 
Related #44667
@Tyriar
Copy link
Member

Tyriar commented Jun 22, 2018

Closing as designed since no other complaints are come through. The split button is next to the delete button now, plus I don't think we should have a kill group command.

@Tyriar Tyriar closed this as completed Jun 22, 2018
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Jun 22, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed terminal Integrated terminal issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @ramya-rao-a