Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue reporter: size exceeds maximum for empty performance report #44733

Closed
egamma opened this issue Feb 28, 2018 · 2 comments
Closed

Issue reporter: size exceeds maximum for empty performance report #44733

egamma opened this issue Feb 28, 2018 · 2 comments
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
February 2018

Comments

@egamma
Copy link
Member

egamma commented Feb 28, 2018

On windows:

  • Open vscode workspace
  • Help>Report Issue
  • Select ´Performance Issue´
  • Enter minimal description

-> size exceeded

image

This is caused by a large process listing. We should look into making it more compact.

image

As a work around we could offer to copy the process list and tell the user to add it manually to the issue report.
@egamma
Copy link
Member Author

egamma commented Feb 28, 2018

Actually the process list differs from code-insiders --status and I also find the process list from code-insiders --status easier to read. The table formatting doesn´t add any value to me. How about just rendering the process list raw like this:

CPU %   Mem MB     PID  Process
    0      104   15108  code-insiders main
    0       72    2188     shared-process
    0       74   13488     shared-process
    0      324   13604     gpu-process
    0      177   18748     window (package.nls.json - npm - Visual Studio Code - Insiders)
    0       73    6592       extensionHost
    0       44    1876         electron_node jsonServerMain.js
    0       14    7400       watcherService
    0       10   21372         console-window-host (Windows internal process)
    0      189   19520     window (Running Extensions - vscode - Visual Studio Code - Insiders)
    0       14    7232       watcherService
    0       10   12228         console-window-host (Windows internal process)
    0       51   10024       extensionHost
    0       32   19896       terminal
    0        6   21088         winpty-process
    0       10    5152           console-window-host (Windows internal process)
    0        4   14024           C:\WINDOWS\System32\cmd.exe
    0       33   20384             electron_node cli.js
    0       52    5844               "C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe" --status
    0       74    1788                 powershell.exe -NoProfile -ExecutionPolicy Bypass -Command "& {& 'c:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\base\node\ps-win.ps1' -ProcessName 'Code - Insiders.exe' -MaxSamples 3}"
    0        7   13536                   console-window-host (Windows internal process)
    0       28    6780                 gpu-process

RMacfarlane pushed a commit that referenced this issue Feb 28, 2018
Issue Reporter: Copy data to clipboard when url exceeds max length, #…
ac84232 
…44733
@RMacfarlane
Copy link
Contributor

For addressing the size issue, I changed the behavior so that when the url is too long, the body of the issue gets copied into the clipboard and the issue preview opens with the text "We have written the needed data into your clipboard because it was too large to send. Please paste."

@RMacfarlane RMacfarlane added this to the February 2018 milestone Feb 28, 2018
@RMacfarlane RMacfarlane added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2018
RMacfarlane pushed a commit that referenced this issue Feb 28, 2018
Change process list formatting to raw instead of table, fixes ##44733
8e8749f
@tsalinger tsalinger added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@egamma @RMacfarlane @tsalinger