Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drag to expand cursor shows but click and dragging has no effect #44866

Closed
mjbvz opened this issue Mar 1, 2018 · 6 comments
Closed

Drag to expand cursor shows but click and dragging has no effect #44866

mjbvz opened this issue Mar 1, 2018 · 6 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verification-found Issue verification failed verified Verification succeeded
Milestone
February 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 1, 2018 •
edited

Issue Type: Bug

Steps to reproduce

  1. For a drag to expand panel (split editors for example)
  2. Move slowly cursor until it just starts showing the drag cursor
  3. Click to drag.

Bug
Nothing happens. Moving the cursor closer to the draggable edge allows dragging

mar-01-2018 13-09-02

/cc @chrisdias

VS Code version: Code - Insiders 1.21.0-insider (9a04587, 2018-03-01T06:39:57.509Z)
OS version: Darwin x64 17.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
Load (avg) 2, 3, 3
Memory (System) 16.00GB (0.21GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_5973426
Screen Reader no
VM 22%
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug workbench labels Mar 1, 2018
@vscodebot vscodebot bot added the insiders label Mar 1, 2018
@bpasero bpasero added layout General VS Code workbench layout issues and removed workbench labels Mar 2, 2018
@bpasero
Copy link
Member

bpasero commented Mar 2, 2018

@isidorn I can reproduce when I start to drag to the far right of the sidebar-sash and it looks like the centered-editor-layout sash is actually in the editor even though centered editor mode is not enabled. I think the sash should be hidden completely unless centered editor mode is turned on.

image

@bpasero bpasero removed their assignment Mar 2, 2018
@isidorn isidorn added this to the February 2018 milestone Mar 2, 2018
@isidorn isidorn closed this as completed in 6e0ffe2 Mar 2, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Mar 2, 2018

Tested in latest master. Split editors seem fixed but I still see this on the boundary between the editor and the sidebar

@mjbvz mjbvz reopened this Mar 2, 2018
@mjbvz mjbvz added the verification-found Issue verification failed label Mar 2, 2018
@isidorn isidorn closed this as completed in 70a0161 Mar 5, 2018
isidorn added a commit that referenced this issue Mar 5, 2018
@isidorn
center layout: hide sahses initialy until center layout gets activated
ee303c2 
fixes #44866
@isidorn
Copy link
Contributor

isidorn commented Mar 5, 2018 •
edited

@mjbvz good catch
@bpasero you were correct, they need to be hidden initialy. Somehow this slipped through my fingers.

I have pushed the fix on top of the release branch

@bpasero
Copy link
Member

bpasero commented Mar 5, 2018

@isidorn thanks, I assume you also hide when leaving "Centered Editor" layout again?

@isidorn
Copy link
Contributor

isidorn commented Mar 5, 2018

@bpasero yes

@isidorn
Copy link
Contributor

isidorn commented Mar 6, 2018

@bpasero can you please verify?

@bpasero bpasero added the verified Verification succeeded label Mar 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verification-found Issue verification failed verified Verification succeeded
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@bpasero @isidorn @mjbvz