Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Toggle Editor Group Layout" to more understandable description #44969

Closed
jgclark opened this issue Mar 3, 2018 · 9 comments
Closed
Assignees
Labels
polish Cleanup and polish issue workbench-editors Managing of editor widgets in workbench window
Milestone

Comments

@jgclark
Copy link

jgclark commented Mar 3, 2018

I had to hunt on Stack Overflow to find the answer to my question: can I get VSC to split window horizontally not just vertically? It turns out to be easy, but the "Toggle Editor Group Layout" command to do so isn't obvious at all, at least to me. Is it doing something more than "Toggle Vertical to Horizontal splits"?

It also pointed me to the little icon/button in the explorer, but that was too subtle to discover.

  • VSCode Version: 1.20.1
  • OS Version: 10.12.6
@vscodebot
Copy link

vscodebot bot commented Mar 3, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@liamfmoran
Copy link

Maybe "Toggle Editor Group Layout Orientation/Direction" would make more sense?

@bpasero bpasero added feature-request Request for new features or functionality workbench-editors Managing of editor widgets in workbench window labels Mar 3, 2018
@bpasero bpasero removed their assignment Mar 3, 2018
@vviikk
Copy link

vviikk commented Mar 3, 2018

"Toggle Editor Split Direction". I think the word split is what everyone would be having on their minds.

@jgclark
Copy link
Author

jgclark commented Mar 4, 2018 via email

@rdickert
Copy link

I think the word split is what everyone would be having on their minds

Agreed. This is actually a really important ux issue. I just spent ten minutes of frustration trying to find this command. I only found it because the word "split" was present in this issue. If you want to get fancy, maybe cmd-click on the button could also toggle it.

@preist
Copy link

preist commented May 29, 2018

Took me three StackOverflow searches to figure this one out.

@bpasero
Copy link
Member

bpasero commented Jun 2, 2018

I am closing this given that the grid work has landed on master (see #14909 (comment)) and splitting vertically and horizontally is now much easier and does not require to use this action anymore.

The action is still there though and has been renamed to "Flip Editor Group Layout".

@bpasero bpasero closed this as completed Jun 2, 2018
@bpasero bpasero self-assigned this Jun 2, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 2, 2018
@preist
Copy link

preist commented Jun 12, 2018

@bpasero Why say "editor group layout" when "editor layout" is enough? Also, the word "flip" is not a significant improvement over "toggle".

Users are likely to look for the words: vertical, horizontal and split in this context.

Why not call it something simpler, e.g. "Flip editor split orientation", or "Horizontal editor layout / Vertical editor layout". In my opinion #14909 (comment) does not address the issue above, since "editor group layout" is not a term generally used in this context. 🤔

@bpasero
Copy link
Member

bpasero commented Jun 12, 2018

Looks ugly as **, but I guess its clearer now:

image

bpasero added a commit that referenced this issue Jun 12, 2018
@bpasero bpasero added polish Cleanup and polish issue and removed feature-request Request for new features or functionality labels Jun 14, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue workbench-editors Managing of editor widgets in workbench window
Projects
None yet
Development

No branches or pull requests

6 participants