Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminalPanel: updateTheme should move into a theming participant #45501

Closed
bpasero opened this issue Mar 11, 2018 · 0 comments
Closed

TerminalPanel: updateTheme should move into a theming participant #45501

bpasero opened this issue Mar 11, 2018 · 0 comments
Assignees
@Tyriar
Labels
debt Code quality issues terminal Integrated terminal issues themes Color theme issues
Milestone
April 2018

Comments

@bpasero
Copy link
Member

bpasero commented Mar 11, 2018

It looks like updateTheme is potentially called more than needed. I would suggest to extract that code into a theming participant that is only being called as needed by the theming service.

See this example.
@bpasero bpasero added debt Code quality issues themes Color theme issues labels Mar 11, 2018
@Tyriar Tyriar added this to the April 2018 milestone Mar 23, 2018
@Tyriar Tyriar added the terminal Integrated terminal issues label Mar 23, 2018
@Tyriar Tyriar closed this as completed in 0a969c7 Apr 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
debt Code quality issues terminal Integrated terminal issues themes Color theme issues
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@bpasero @Tyriar