Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

process.env['VSCODE_NLS_CONFIG'] set in main.js will not reach renderer under Linux #4558

Closed
dbaeumer opened this issue Mar 22, 2016 · 1 comment
Closed

process.env['VSCODE_NLS_CONFIG'] set in main.js will not reach renderer under Linux #4558

dbaeumer opened this issue Mar 22, 2016 · 1 comment
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Milestone
March 2016

Comments

@dbaeumer
Copy link
Member

  • VSCode Version: 0.10.12-alpha
  • OS Version: Linux

Steps to Reproduce:

  1. in main.js write to the process.env (see VSCODE_NLS_CONFIG)
  2. the environment variable will not reach the renderer process
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Mar 22, 2016
@dbaeumer dbaeumer added this to the March 2016 milestone Mar 22, 2016
@dbaeumer dbaeumer self-assigned this Mar 22, 2016
@dbaeumer dbaeumer changed the title process.env set in main.js will not reach renderer under Linux process.env['VSCODE_NLS_CONFIG'] set in main.js will not reach renderer under Linux Mar 22, 2016
@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Mar 22, 2016
bpasero added a commit that referenced this issue Mar 22, 2016
@bpasero
Merge pull request #4559 from Microsoft/dbaeumer/4558
e67ed67 
Fixes #4558: process.env['VSCODE_NLS_CONFIG'] set in main.js will not reach renderer under Linux
@dbaeumer dbaeumer assigned bpasero and unassigned dbaeumer Mar 22, 2016
@bpasero bpasero assigned dbaeumer and unassigned bpasero Mar 23, 2016
@dbaeumer dbaeumer assigned bpasero and unassigned dbaeumer Mar 23, 2016
@dbaeumer
Copy link
Member Author

@bpasero you reviewed. Can you please verify.

@bpasero bpasero added the verified Verification succeeded label Mar 23, 2016
@joaomoreno joaomoreno mentioned this issue Apr 28, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
2 participants
@bpasero @dbaeumer