Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help > View License not redirecting properly #4579

Closed
vsccarl opened this issue Mar 22, 2016 · 5 comments
Closed

Help > View License not redirecting properly #4579

vsccarl opened this issue Mar 22, 2016 · 5 comments
Assignees
Labels
candidate Issue identified as probable candidate for fixing in the next release l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone

Comments

@vsccarl
Copy link

vsccarl commented Mar 22, 2016

  • VSCode Version: 0.10.12-alpha
  • OS Version: Windows 10

Steps to Reproduce:

  1. Help -> View License

Actual:
Redirects to http://www.microsoft.com/en-us/

Expected:
Redirect to https://code.visualstudio.com/license#vscode

@chrisdias
Copy link
Member

I think what is going on is that we removed the #vscode from the licenseURL in product.json which means code is now calling http://go.microsoft.com/fwlink/?LinkID=533485?lang=en (appending ?lang=en). It should use & instead of ?. So, we should append &lang=en instead of ?lang=en (obviously replacing en with the appropriate locale).

In src/vs/workbench/electron-main/menus.ts, line 598:

openUrl(${env.product.licenseUrl}**?**lang=${platform.language}, 'openLicenseUrl');

should be:

openUrl(${env.product.licenseUrl}**&**lang=${platform.language}, 'openLicenseUrl');

@vsccarl vsccarl added the v-test label Mar 22, 2016
@chrisdias chrisdias assigned dbaeumer and unassigned chrisdias Mar 22, 2016
@chrisdias chrisdias added this to the March 2016 milestone Mar 22, 2016
@dbaeumer dbaeumer added l10n-platform Localization platform issues (not wrong translations) candidate Issue identified as probable candidate for fixing in the next release labels Mar 23, 2016
@dbaeumer dbaeumer assigned chrisdias and unassigned dbaeumer Mar 23, 2016
@egamma egamma assigned dbaeumer and unassigned chrisdias Mar 29, 2016
@egamma
Copy link
Member

egamma commented Mar 29, 2016

@dbaeumer can you verify this on a clean German machine. When I tried to verify it on my hybrid version I still got the hybrid version.

@dbaeumer
Copy link
Member

I will.

@dbaeumer
Copy link
Member

Here is what I see: Clicking on 'Lizenz anzeigen' opens a browser with the URL https://code.visualstudio.com/license?lang=de

which I think is correct. The page stills shows an English pre license so.

@dbaeumer dbaeumer added the verified Verification succeeded label Mar 29, 2016
@chrisdias
Copy link
Member

yes, this is correct url. when we push a new build of the website it will redirect to the localized page.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
candidate Issue identified as probable candidate for fixing in the next release l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants