-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Centered editor layout shuold be per workspace not window #46277
Comments
(Experimental duplicate detection) |
We decided for th ecntered editor layour to be preserved across workspaces https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/editorGroupsControl.ts#L1059 This is just a design decision we took. So let's keep this issue open and wait for more feedback to potentially change that If editor are horizontal or vertical is stored per workspace. So it makes sense to align with that imho fyi @SrTobi |
No, I think @jeffhube is right... the problem is not that the centered editor is stored in The main problem is the following: when we transition to zenmode we change all kind of things (we toggle the centered layout, we hide the sidebar etc) and we do it in a way that the user thinks it's temporal (which it kind of is, because it will be reset when we exit the zenmode) but the things that are changed do save their state permanent by saving it into the storage. That's why the new window thinks centered layout should still be active... We could fix that (and by fix I mean “make it seem to work”) by changing the storage scope to workspace but as @isidorn pointed out that isn't a good solution because the centered layout should be aligned to the vertical/horizontal setting I don't see how we can fix this without somehow rewriting the code for the save procedure of all the things zenmode changes... because they should not save their state if they are only temporarily changed because of the zenmode If we want to address this (and I think we should) it could also be the solution for what I mentioned in #45773... luckily I haven't started to implement anything 😄 |
Nothing for this milestone since we are in endgame week, thus I am assigning it to the april milestone so we can discuss this in greater detail when I am back from vacation in about 2 weeks. |
I was on vacation for the previous milestone thus pushing this to May. |
This is a very nasty problem... I think a solution would be to not save the state of the centered layout if it was activated because of transitioning to zen mode. |
After looking into this I decided to store the centered editor layout per workspace not per user. Since all our other layout storage is stored per workspace. @SrTobi you can try it out in the insiders from tomorrow and if you still see some corner cases where this is not behaving as expected please create a new issue which would be great - thanks a lot! |
I really like the centered layout feature. Unfortunately the centered view gets lost on diff views, even if inline diff is activated. Having a centered layout here also would make me really happy. :))) |
Yeah, we did that intentionally because we thought that the user would want to use the full editor space when watching two files side by side. Could you maybe elaborate why/how you are using the centered layout? Is your screen just that wide 😃 or is there another usecase here that needs the diff view centered? |
Ah ok, makes sense 😄 As I see it, the layout of vscode is currently being reworked and so is the centered mode. It isn't even working on |
Issue Type: Bug
Expected behavior: the new window is not using the zen mode centered layout
Actual behavior: the new window is using the zen mode centered layout
This seems similar to #45610 , except vscode isn't being closed.
VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.16299
System Info
Extensions (14)
The text was updated successfully, but these errors were encountered: