Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task exit code is set to 1 regardless of problem severity #46439

Closed
Gama11 opened this issue Mar 23, 2018 · 2 comments
Closed

Task exit code is set to 1 regardless of problem severity #46439

Gama11 opened this issue Mar 23, 2018 · 2 comments
Assignees
@dbaeumer
Labels
tasks Task system issues verified Verification succeeded
Milestone
April 2018

Comments

@Gama11
Copy link
Contributor

Gama11 commented Mar 23, 2018 •
edited

Issue Type: Bug

terminalTaskSystem.ts has a section of code that sets the exitCode of a task to 1 purely based on whether or not the problem matcher has any matches:

https://github.com/Microsoft/vscode/blob/9de24bfa5bcd2a7cb5bf4e3f6bf711bc9f20290e/src/vs/workbench/parts/tasks/electron-browser/terminalTaskSystem.ts#L366-L369

This seems incorrect, as the severity of those matches also has to be considered - this check should only trigger if at least one of the matches has MarkerSeverity.Error. In this case, a single warning is enough to trigger it (severity 4):

Which means the debugger isn't launched if such a task is used as a preLaunchTask, despite there not being any errors:

This was originally reported to us at the Haxe extension here: vshaxe/vshaxe#180

VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.16299
@vscodebot vscodebot bot added the tasks Task system issues label Mar 23, 2018
@Gama11 Gama11 mentioned this issue Mar 23, 2018
Closed
@dbaeumer
Copy link
Member

The underlying problem is deeper than this. The terminal itself doesn't always report the correct exit code. I will recheck what the current status with the terminal is.

@dbaeumer dbaeumer added this to the April 2018 milestone Mar 26, 2018
@dbaeumer
Copy link
Member

To verify:

@mjbvz mjbvz added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@dbaeumer @Gama11 @mjbvz