Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong case / Symbolic link as root folder does not report file events #46538

Closed
bpasero opened this issue Mar 26, 2018 · 1 comment
Closed

Wrong case / Symbolic link as root folder does not report file events #46538

bpasero opened this issue Mar 26, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-watcher File watcher macos Issues with VS Code on MAC/OS X verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues

Comments

@bpasero
Copy link
Member

bpasero commented Mar 26, 2018

Note: this reproduces on macOS only

Steps to Reproduce (link):

  1. ln -s source target on a folder to link it to another folder
  2. add this linked folder as single entry to a workspace file
  3. open that workspace file
  4. change files outside and see the explorer not updating

Steps to Reproduce (wrong casing):

  1. add a folder to a workspace config file that uses wrong case (e.g. desktop instead of Desktop)
  2. open that workspace file
  3. change files outside and see the explorer not updating

=> it looks like the NSFW watcher service should probably do a similar trick as our chokidar watcher and realcase the folder path (and possible realpath to resolve the link first).

The important thing is to restore the original path from the file events to not confuse the consumers.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-multiroot Multi-root (multiple folders) issues file-watcher File watcher labels Mar 26, 2018
@bpasero bpasero assigned bpasero and unassigned Tyriar Sep 5, 2018
@bpasero bpasero added the macos Issues with VS Code on MAC/OS X label Sep 5, 2018
@bpasero bpasero added this to the September 2018 milestone Sep 5, 2018
@bpasero bpasero closed this as completed in 2b4a8c0 Sep 5, 2018
@bpasero
Copy link
Member Author

bpasero commented Sep 5, 2018

I am now first doing realpathSync to see if the path is a symbolic link and then realcaseSync to see if casing is wrong.

@chrmarti chrmarti added the verified Verification succeeded label Sep 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-watcher File watcher macos Issues with VS Code on MAC/OS X verified Verification succeeded workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants