Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Create file In' explorer notification does not update/dismiss after you delete path separator in new name #46744

Closed
mjbvz opened this issue Mar 27, 2018 · 1 comment
Closed

'Create file In' explorer notification does not update/dismiss after you delete path separator in new name #46744

mjbvz opened this issue Mar 27, 2018 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone
April 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Mar 27, 2018 •
edited

Testing #46328

  • VSCode Version: Version 1.22.0-insider (1.22.0-insider)
  • OS Version: MacOS 10.13.3

Steps to Reproduce:

  1. Create a new file in the explorer
  2. In new file input, type a forward slash then delete the slash

Bug
The 'create file in' notification is still showing but no longer updates

mar-27-2018 11-29-07

Does this issue occur when all extensions are disabled?: Yes/No
@vscodebot vscodebot bot added the insiders label Mar 27, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 28, 2018

@mjbvz this is a good catch, forawrding to Till to investigate since he owns this feature.
Also assigning to April since it is nothing critical

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues and removed insiders labels Mar 28, 2018
@isidorn isidorn added this to the April 2018 milestone Mar 28, 2018
@isidorn isidorn assigned tsalinger and unassigned isidorn Mar 28, 2018
isidorn added a commit that referenced this issue Apr 17, 2018
@isidorn
Merge pull request #48042 from Microsoft/tsalinger/multi-path-notific…
f436fd3 
…ation-not-dismissed-after-del-slash

fixes #46744: inputbox hides again if all slashes are removed
@sbatten sbatten added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
4 participants
@isidorn @sbatten @mjbvz @tsalinger