Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codelens Freezes when double clicking in the codelens view. #46893

Closed
atlv24 opened this issue Mar 29, 2018 · 11 comments
Closed

Codelens Freezes when double clicking in the codelens view. #46893

atlv24 opened this issue Mar 29, 2018 · 11 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Milestone
April 2018

Comments

@atlv24
Copy link

atlv24 commented Mar 29, 2018 •
edited

Issue Type: Bug

Open any project that has language support for reference counting and codelens, click on one of the 2 references (or any number) links to open a Codelens view. Edit something in the codelens view (like add a comment, or anything really) and do not save. Now double click in the codelens view, to go to the file in full view mode.

Expected results: takes you to the file, leaving codelens.

Actual result: codelens glitches out and stops being interactable, cannot be closed, and often glitches out line numbers in the reference display. It also prints this in the corner if I try to close the codelens view clicking a reference count link:

Cannot read property 'getStartPosition' of null.

and if I press escape:

Cannot read property 'getStartPosition' of null

Doing a vs-code soft reload (reload command) fixes the bugged out codelens view, but the line number references are all garbled and highlight non-matching things, not the actual references. This persists past saves and soft reloads, the only way to fix is to actually quit the app and open it again. I did not file separate issues for these two problems (window being frozen, and line numbers being off) because they seem to have the same root cause: codelens not working properly with unsaved file modifications.

VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:39:09.335Z)
OS version: Darwin x64 17.4.0

System Info
Item Value
CPUs Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz (16 x 3200)
Load (avg) 1, 1, 1
Memory (System) 32.00GB (18.28GB free)
Process Argv /Applications/Visual Studio Code.app/Contents/MacOS/Electron
Screen Reader no
VM 0%
Extensions (11)
Extension Author (truncated) Version
haskelly UCL 0.4.29
idris-highlighting arc 0.0.2
code-runner for 0.9.3
language-haskell jus 2.4.0
python ms- 2018.2.1
cpptools ms- 0.15.0
csharp ms- 1.14.0
shader sle 1.1.2
cmake twx 0.0.17
cmake-tools vec 0.10.4
Idris zjh 0.9.8
Reproduces only with extensions
@vscodebot
Copy link

vscodebot bot commented Mar 29, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@jrieken jrieken added the info-needed Issue requires more information from poster label Mar 29, 2018
@jrieken
Copy link
Member

jrieken commented Mar 29, 2018

Can you attach the stack trace that printed onto the console (F1 > Developer Tools > Console) or even better, select 'Break on all errors' in F1 > Developer Tools > Sources and provide the full trace and source (screen shot is enough) when this happens. Thanks

@atlv24
Copy link
Author

atlv24 commented Mar 29, 2018

Here it is:
screen shot 2018-03-29 at 12 07 33 pm
screen shot 2018-03-29 at 12 08 30 pm
Thanks

@jrieken
Copy link
Member

jrieken commented Apr 3, 2018

Thanks. That's a good stack trace but it seems to come from the suggest widget... In your original comment you mentioned getStartPosition is called on null. Can you also reproduce that?

@atlv24
Copy link
Author

atlv24 commented Apr 3, 2018

Sure! Im not sure what the suggest widget is, but if I hit resume execution it immediately errors again and yields the stack trace you are looking for:
screen shot 2018-04-03 at 12 33 21 am
screen shot 2018-04-03 at 12 33 38 am

@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Apr 3, 2018
@jrieken
Copy link
Member

jrieken commented Apr 3, 2018

Thanks.

@jrieken jrieken added this to the April 2018 milestone Apr 3, 2018
jrieken added a commit that referenced this issue Apr 3, 2018
@jrieken
don't read null range, #46893
268ec64
@jrieken
Copy link
Member

jrieken commented Apr 3, 2018

I was able to reproduce but I have pushed code to prevent the getStartPosition error from happening. Please try soon again with insiders. Leaving the suggest widget to @ramya-rao-a

@jrieken jrieken removed their assignment Apr 3, 2018
@jrieken jrieken added suggest IntelliSense, Auto Complete and removed info-needed Issue requires more information from poster labels Apr 3, 2018
@ramya-rao-a
Copy link
Contributor

@rodolphito I can repro this only in Stable 1.21 but not in Insiders. Can you try the latest Insiders?

@jrieken You were able to repro this in stable or insiders?

@jrieken
Copy link
Member

jrieken commented Apr 4, 2018

Ops, should have said 'I was not able to reproduce'... I just added some fail-safe code without reproducing...

@atlv24
Copy link
Author

atlv24 commented Apr 4, 2018

I can confirm it does not happen anymore in the latest insiders build. Thanks!

@jrieken
Copy link
Member

jrieken commented Apr 4, 2018 •
edited

Ok, thanks

@jrieken jrieken closed this as completed Apr 4, 2018
@roblourens roblourens added the verified Verification succeeded label Apr 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
4 participants
@roblourens @jrieken @atlv24 @ramya-rao-a