Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surveys: listen to model save events instead of generic file events #46917

Closed
bpasero opened this issue Mar 29, 2018 · 2 comments
Closed

Surveys: listen to model save events instead of generic file events #46917

bpasero opened this issue Mar 29, 2018 · 2 comments
Assignees
@isidorn
Labels
debt Code quality issues
Milestone
April 2018

Comments

@bpasero
Copy link
Member

bpasero commented Mar 29, 2018

I would like to reduce our dependency to file events as much as possible and one client seems to be languageSurveys.contribution.ts. Instead of listening for each updated file I suggest to listen to model save events from the ITextFileEditorModelManager.
@bpasero bpasero added the debt Code quality issues label Mar 29, 2018
@isidorn
Copy link
Contributor

isidorn commented Apr 13, 2018

@bpasero can you please review my change
fyi @joaomoreno

@isidorn isidorn added this to the April 2018 milestone Apr 13, 2018
@bpasero
Copy link
Member Author

bpasero commented Apr 16, 2018

@isidorn lgtm thanks

@vscodebot vscodebot bot locked and limited conversation to collaborators May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
debt Code quality issues
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@bpasero @isidorn