Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marketplace category "Languages" changed to "Programming Languages" #47103

Closed
gregvanl opened this issue Apr 2, 2018 · 6 comments
Closed

Marketplace category "Languages" changed to "Programming Languages" #47103

gregvanl opened this issue Apr 2, 2018 · 6 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@gregvanl
Copy link

gregvanl commented Apr 2, 2018

The Marketplace has changed the "Languages" category to "Programming Languages" (to differentiate the category from "Language Packs")

The vscode extension package.json schema needs to be updated, (src\vs\workbench\services\extensions\common\extensionsRegistry.ts) as well as the vscode-generator-code ext-language template.

There may be other changes required.

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Apr 2, 2018
@roblourens
Copy link
Member

Should it be fixed for 1.22 @gregvanl?

@aeschli
Copy link
Contributor

aeschli commented Apr 3, 2018

I pushed some changes to master (1.23).
Now there's a validation error if you still use 'Languages' in categories.
So for a better user experience, we should push the change to 1.22 as well.

I will update the vscode-generator-code as soon as the change is in a stable build.

@aeschli aeschli added this to the April 2018 milestone Apr 3, 2018
@aeschli
Copy link
Contributor

aeschli commented Apr 3, 2018

I pushed a improvement that 'Languages' only gets a deprecated warning (not an error). So no need to rush this in 1.22.

@aeschli
Copy link
Contributor

aeschli commented Apr 18, 2018

Also pushed changes to our yeoman generator.

Marking as fixed. @gregvanl Do you coordinate the other changes?
That's what I imagine:
In the marketplace: Covert all published extensions that use 'Languages' to use 'Programming Languages'
Give good error feedback when trying to publish an extension still using 'Languages'

aeschli added a commit to microsoft/vscode-generator-code that referenced this issue Apr 18, 2018
@gregvanl
Copy link
Author

gregvanl commented Apr 18, 2018

@aeschli I haven't been coordinating this, I just heard from @seanmcbreen about the change with respect to the docs and figured we'd need to change the product to match. I'm not sure what further work the Marketplace has planned for updating existing extensions or providing feedback.

@aeschli aeschli closed this as completed Apr 18, 2018
@aeschli aeschli added the feature-request Request for new features or functionality label Apr 22, 2018
@aeschli
Copy link
Contributor

aeschli commented Apr 22, 2018

Verifiers:
Create an extension that uses the old keyword ('Languages') and verify that you get a warning.

@chrmarti chrmarti added the verification-needed Verification of issue is requested label Apr 24, 2018
@isidorn isidorn added the verified Verification succeeded label Apr 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants