Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeLens at top of file keeps getting scrolled out of sight (regression in 1.22.1 from 1.21.1) #47703

Closed
StephenWeatherford opened this issue Apr 11, 2018 · 8 comments
Closed

CodeLens at top of file keeps getting scrolled out of sight (regression in 1.22.1 from 1.21.1) #47703

StephenWeatherford opened this issue Apr 11, 2018 · 8 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Milestone
April 2018

Comments

@StephenWeatherford
Copy link

Issue Type: Bug

  1. Install from extension VSIX from https://azcode.blob.core.windows.net/vscode-cosmosdb/saw/codelens/1414/vscode-cosmosdb-0.6.0.vsix
  2. In explorer, open "Azure Cosmos DB" and click on the "New Mongo Scrapbook" icon in its titlebar
    !) the "Connect to a database" CodeLens at the top is completely hidden
  3. Scroll it into view
  4. Type something
    !) it hides again
  5. Scroll it into view
  6. Delete the line you typed in C# bracket insertion, indentation not working #4 and press ENTER
    !) it hides again

etc.

NOTE: This also repros with other extensions, e.g. donjayamanne.jupyter

This started in 1.22.1, does not repro in 1.21.1.

VS Code version: Code 1.22.1 (950b8b0, 2018-04-06T02:26:57.615Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Xeon(R) CPU E31230 @ 3.20GHz (4 x 3193)
Memory (System) 15.96GB (6.83GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (16)
Extension Author (truncated) Version
mongogo bag 0.1.2
regex chr 0.1.0
vscode-markdownlint Dav 0.14.1
githistory don 0.4.0
tslint eg2 1.0.28
vscode-bump fab 1.4.1
docthis joe 0.6.0
vscode-antlr4 mik 2.0.2
azure-account ms- 0.4.0
csharp ms- 1.14.0
azurerm-vscode-tools msa 0.4.0
vscode-versionlens pfl 0.20.0
yo sam 0.9.3
extension-api spy 0.2.0
python tht 0.2.3
code-lens-roundup wad 1.0.0
@StephenWeatherford
Copy link
Author

1 22 1 b

This was referenced Apr 12, 2018
Merged
Closed
@vscodebot vscodebot bot removed the new release label Apr 12, 2018
@jrieken jrieken added code-lens bug Issue identified by VS Code Team member as probable bug labels Apr 12, 2018
@jrieken
Copy link
Member

jrieken commented Apr 12, 2018

@alexandrudima Did something change here?

@Jarrio
Copy link

Jarrio commented Apr 12, 2018 •
edited

Not sure if this is related, but in the current version of vscode this also happens to me:
gif
Turning off code lens fixes this

@alexdima
Copy link
Member

@Jarrio Can you please create a separate issue where you can maybe provide in textual form the typescript file which would reproduce the issue.

@alexdima
Copy link
Member

Yes, 7a3204c which changes the revealing strategy to maintain/reveal the top most line in the viewport when code lens change (it used to be the centered line in the viewport).

We can bring up the check that if the original scrollTop is 0, then don't do anything.

@alexdima alexdima added this to the April 2018 milestone Apr 13, 2018
@Jarrio
Copy link

Jarrio commented Apr 13, 2018

@alexandrudima I am actually using a language called Haxe, is this a bug with the language extension or vscode?

@alexdima
Copy link
Member

@Jarrio Extensions have API to reveal an editor range (i.e. scroll the editor). There might be an extension you have installed which uses this API, I don't know ...

@StephenWeatherford
Copy link
Author

Works in Insiders, thanks!

@mjbvz mjbvz added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug code-lens verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
5 participants
@Jarrio @jrieken @alexdima @StephenWeatherford @mjbvz