Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't call URI#fsPath unless scheme is file #47738

Closed
jrieken opened this issue Apr 12, 2018 · 0 comments
Closed

Don't call URI#fsPath unless scheme is file #47738

jrieken opened this issue Apr 12, 2018 · 0 comments
Assignees
@isidorn
Labels
verified Verification succeeded
Milestone
April 2018

Comments

@jrieken
Copy link
Member

jrieken commented Apr 12, 2018 •
edited

The URI#fsPath property is for convince and helps reading files from disk. That means it is only meaningful for the file-scheme and should not be used for other schemes. The following code has been identified as being an offender:

https://github.com/Microsoft/vscode/blob/da9720b39b1a912ce8009587731d824a890797ad/src/vs/base/common/resources.ts#L12
@isidorn isidorn added this to the April 2018 milestone Apr 13, 2018
@tsalinger tsalinger added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@jrieken @isidorn @tsalinger