Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having so much red underlined code (errors) makes VSCode very slow to edit these files #47758

Closed
sharno opened this issue Apr 12, 2018 · 3 comments
Closed

Having so much red underlined code (errors) makes VSCode very slow to edit these files #47758

sharno opened this issue Apr 12, 2018 · 3 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Milestone
April 2018

Comments

@sharno
Copy link

sharno commented Apr 12, 2018

  • VSCode Version: 1.22.1
  • OS Version: MacOS 10.12.6

Steps to Reproduce:
(I'm using the Flow Language Support extension and mostly experience it when the extension marks a big bunch of code as having errors but this issue spans other files that have large amount of text with errors.)

  1. Have a big amount of text underlined in red (having errors)
  2. Performance of VSCode in this file becomes so slow to be able to edit this file
@vscodebot vscodebot bot added editor editor-core Editor basic functionality labels Apr 12, 2018
@alexdima
Copy link
Member

@sharno Can you please give a very specific example, like a file which reproduces this consistently for you

@alexdima alexdima added info-needed Issue requires more information from poster and removed editor editor-core Editor basic functionality labels Apr 13, 2018
@sharno
Copy link
Author

sharno commented Apr 13, 2018

@alexandrudima
I don't remember though how to reproduce it in other files without using Flow.
So, this is a dummy repo I made for this issue: https://github.com/sharno/vscode-performance-errors. You'll probably just need to do an npm install and install the Flow Language Support extension to make the errors appear in the editor

@alexdima
Copy link
Member

I can reproduce some slowness. Each line has about 15 errors. i.e. there are 15 errors that span almost the entire file. The browser is a bit struggling to paint so many squiggles. Note the somewhat high Paint times:

image

To investigate if we could deduplicate error squiggles and have only one drawn per line instead of the current N overlapping.

@alexdima alexdima added freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues editor-rendering Editor rendering issues bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Apr 13, 2018
@alexdima alexdima added this to the April 2018 milestone Apr 13, 2018
@mjbvz mjbvz added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug editor-rendering Editor rendering issues freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
4 participants
@sharno @rebornix @alexdima @mjbvz