Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support typescript's fixName code action property #47760

Closed
mjbvz opened this issue Apr 12, 2018 · 2 comments
Closed

Support typescript's fixName code action property #47760

mjbvz opened this issue Apr 12, 2018 · 2 comments
Assignees
@mjbvz
Labels
typescript Typescript support issues verified Verification succeeded
Milestone
May 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 12, 2018 •
edited

Add support for the new fixName property ts is adding to code actions microsoft/TypeScript#23350
@mjbvz mjbvz added the typescript Typescript support issues label Apr 12, 2018
@mjbvz mjbvz added this to the May 2018 milestone Apr 12, 2018
@mjbvz mjbvz self-assigned this Apr 12, 2018
@mjbvz mjbvz closed this as completed in f8ced19 May 4, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label May 4, 2018
@isidorn isidorn added the verification-steps-needed Steps to verify are needed for verification label May 29, 2018
@isidorn
Copy link
Contributor

isidorn commented May 29, 2018

@mjbvz please provide verifications steps. thanks

@mjbvz
Copy link
Contributor Author

mjbvz commented May 29, 2018

Thanks for taking a look. This was only for telemetry and I just verified that the fixNameproperty is being sent properly myself:

RawEventsVSCodeExt 
| where EventName contains 'typescript'
| where EventName contains 'quickfix'
| project Fix = tostring(Properties['fixname'])
| summarize count(Fix) by Fix

@mjbvz mjbvz added verified Verification succeeded and removed verification-needed Verification of issue is requested verification-steps-needed Steps to verify are needed for verification labels May 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
typescript Typescript support issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@isidorn @mjbvz