Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong alert message when deleting multiple directories #47892

Closed
prajapati-parth opened this issue Apr 15, 2018 · 5 comments
Closed

Wrong alert message when deleting multiple directories #47892

prajapati-parth opened this issue Apr 15, 2018 · 5 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2018

Comments

@prajapati-parth
Copy link

  • VSCode Version:
    1.22.2
  • OS Version:
    macOS High Sierra 10.13.2

Steps to Reproduce:

  1. Hold Cmd and select more than one directories in VSCode Explorer.
  2. Press Cmd + delete to delete them.
  3. The popup alert confirms to delete files not directories.

Expected message:
Are you sure you want to delete the following 2 directories?

Actual message:
Are you sure you want to delete the following 2 files?

Screenshot:
screen shot 2018-04-15 at 10 00 09 am

Does this issue occur when all extensions are disabled?:
Yes
@isidorn
Copy link
Contributor

isidorn commented Apr 16, 2018

Yes this message can be improved.
We accept PRs that fix this
Code pointer https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/files/electron-browser/fileActions.ts#L636

@isidorn isidorn added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality file-explorer Explorer widget issues labels Apr 16, 2018
@isidorn isidorn removed their assignment Apr 16, 2018
@isidorn isidorn added this to the Backlog milestone Apr 16, 2018
@prajapati-parth
Copy link
Author

WOW! Thanks for the code pointer. Will send a PR for this. Keep it for me. 👍
Thanks.

@pradeepmurugesan pradeepmurugesan mentioned this issue Apr 16, 2018
Merged
@pradeepmurugesan
Copy link
Contributor

@prajapati-parth Sorry.. I didn't leave a message that I was already on it..

@bpasero bpasero added the verification-needed Verification of issue is requested label Apr 20, 2018
@bpasero bpasero modified the milestones: Backlog, April 2018 Apr 20, 2018
@bpasero bpasero self-assigned this Apr 20, 2018
@bpasero bpasero removed the help wanted Issues identified as good community contribution opportunities label Apr 20, 2018
@bpasero bpasero closed this as completed Apr 20, 2018
@bpasero
Copy link
Member

bpasero commented Apr 20, 2018

Verify: the confirmation dialog when deleting files/folders in the explorer has the correct wording in these cases:

  • single file
  • single folder
  • multi file
  • multi folder
  • mixed file/folder selection

Also verify when bypassing the trash (hold shift (mac: alt) key and select the delete action)

@isidorn isidorn added the verified Verification succeeded label Apr 24, 2018
@isidorn
Copy link
Contributor

isidorn commented Apr 24, 2018 •
edited

Verified the message is good now, just polished the grammer in massage (changed 'its' to 'their')

isidorn added a commit that referenced this issue Apr 24, 2018
@isidorn
polish message
a738956 
fixes #47892
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
4 participants
@pradeepmurugesan @bpasero @isidorn @prajapati-parth