-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support mkdirp when saving files #48062
Comments
/cc @weinand This is for the debug scenario. |
/cc @isidorn |
@bpasero for debug there is no issue. The problem is that debug was relying on "mkdirp" when creating ".vscode/launch.json". But the remote filesystem provider doesn't use "mkdirp", so our code was failing there. |
You wanna set it to |
@jrieken I think that depends. the file you have opened could have been deleted (including its parent folders) and our current behaviour is to restore the full path and file when you save it. Otherwise the behaviour would be weird:
=> you would get an error if |
We now do that... |
There are scenarios, like creating
.vscode/launch.json
that assume we always runmkdirp
-logic first. While that make sense for new files it doesn't make sense for files we have opened before, e.g. files users edit. Too address these scenarios I have addedIUpdateContentOptions#mkdirp
and theRemoteFileService
honours that flag, the default file service always runsmkdirp
I believe (cc @bpasero).The text was updated successfully, but these errors were encountered: