Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File watcher fails with chinese characters in path #481

Closed
leixu2txtek opened this issue Nov 23, 2015 · 18 comments
Closed

File watcher fails with chinese characters in path #481

leixu2txtek opened this issue Nov 23, 2015 · 18 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@leixu2txtek
Copy link

First of all , Thanks to all contributor

When i use the lastest version to build my node app, i want to debug my app..

when i add the launch.json , but not appear in the launch configuration dropdown menu.

So , i guess need restart the VSCode , Yes... did it...

Maybe it's a tiny bug...

thx.

OS : Windows 10 pro 10586

@isidorn isidorn added the info-needed Issue requires more information from poster label Nov 23, 2015
@isidorn
Copy link
Contributor

isidorn commented Nov 23, 2015

Ok, so:

  • You manually create a launch.json file
  • You open the debug viewlet but you do not see the configurations in the launch dropdown

Did I understand your steps properly? Because I can not reproduce this beahvior.
Providing more precise steps would be useful, especially how you add the launch.json

@isidorn
Copy link
Contributor

isidorn commented Nov 23, 2015

Might it be a duplicate of #458 ?

@leixu2txtek
Copy link
Author

ok . . not manually...

click the debug button

selected the node js

need restart

can't open the dropdown menu ,need restart the VSCode.

thx.

@isidorn
Copy link
Contributor

isidorn commented Nov 24, 2015

@bpasero seems like file events are missing here. Any idea why that might be?

@isidorn isidorn removed the info-needed Issue requires more information from poster label Nov 24, 2015
@bpasero
Copy link
Member

bpasero commented Nov 24, 2015

Easy to find out running with --verbose

@isidorn
Copy link
Contributor

isidorn commented Nov 24, 2015

@leixu2txtek we believe you might be missing file events, though you would see this in other places as well (git viewlet not being updated with a badge once you make changes). Can you run code with --verbose flag and via palette open developer: toggle developer tools and post the screenshot frmo the output if there are file events comming

@isidorn isidorn added the info-needed Issue requires more information from poster label Nov 24, 2015
@leixu2txtek
Copy link
Author

ok...

dev

@isidorn isidorn changed the title [Debug] add the launch.json but not appear in the launch configuration dropdown menu launch.json configuration does not appear in the launch dropdown menu Nov 24, 2015
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 24, 2015
@bpasero
Copy link
Member

bpasero commented Nov 24, 2015

Hm, maybe the path uses characters we fail to decode. If you delete a file in the windows explorer, does the explorer in VSCode update?

@leixu2txtek
Copy link
Author

Maybe... you know, I am Chinese people...

i'll test it with full english path

thx

@leixu2txtek
Copy link
Author

@bpasero @isidorn

Yes.. Really it is because of Chinese characters...

thx..

@leixu2txtek
Copy link
Author

@bpasero VSCode does not automatically update, I need to manually refresh.

@bpasero bpasero changed the title launch.json configuration does not appear in the launch dropdown menu File watcher fails with chinese characters in path Nov 25, 2015
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug and removed debug Debug viewlet, configurations, breakpoints, adapter issues info-needed Issue requires more information from poster labels Nov 25, 2015
@bpasero bpasero assigned bpasero and unassigned isidorn Nov 25, 2015
@bpasero
Copy link
Member

bpasero commented Nov 25, 2015

@leixu2txtek can you give me an example path so that I can try to reproduce.

@leixu2txtek
Copy link
Author

@bpasero :)

D:\新建文件夹\中文项目目录

@bpasero
Copy link
Member

bpasero commented Nov 25, 2015

Wow this is a great bug, turns out we need to set UTF-8 when writing from C# to the console. I think I have a fix for it.

@leixu2txtek
Copy link
Author

@bpasero Nice... 👍

@bpasero
Copy link
Member

bpasero commented Nov 26, 2015

@leixu2txtek I pushed a fix and you can patch your vscode to pick it up:

@bpasero bpasero closed this as completed Nov 26, 2015
@leixu2txtek
Copy link
Author

@bpasero worked .. thx

@bpasero
Copy link
Member

bpasero commented Nov 26, 2015

Great 👍

@bpasero bpasero modified the milestone: Dec 2015 Nov 26, 2015
@bpasero bpasero assigned alexdima and unassigned bpasero Dec 15, 2015
@bpasero bpasero added the verified Verification succeeded label Jul 1, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants
@bpasero @isidorn @alexdima @leixu2txtek and others