-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File watcher fails with chinese characters in path #481
Comments
Ok, so:
Did I understand your steps properly? Because I can not reproduce this beahvior. |
Might it be a duplicate of #458 ? |
@bpasero seems like file events are missing here. Any idea why that might be? |
Easy to find out running with --verbose |
@leixu2txtek we believe you might be missing file events, though you would see this in other places as well (git viewlet not being updated with a badge once you make changes). Can you run code with --verbose flag and via palette open developer: toggle developer tools and post the screenshot frmo the output if there are file events comming |
Hm, maybe the path uses characters we fail to decode. If you delete a file in the windows explorer, does the explorer in VSCode update? |
Maybe... you know, I am Chinese people... i'll test it with full english path thx |
@bpasero VSCode does not automatically update, I need to manually refresh. |
@leixu2txtek can you give me an example path so that I can try to reproduce. |
@bpasero :) D:\新建文件夹\中文项目目录 |
Wow this is a great bug, turns out we need to set UTF-8 when writing from C# to the console. I think I have a fix for it. |
@bpasero Nice... 👍 |
@leixu2txtek I pushed a fix and you can patch your vscode to pick it up:
|
@bpasero worked .. thx |
Great 👍 |
First of all , Thanks to all contributor
When i use the lastest version to build my node app, i want to debug my app..
when i add the launch.json , but not appear in the launch configuration dropdown menu.
So , i guess need restart the VSCode , Yes... did it...
Maybe it's a tiny bug...
thx.
OS : Windows 10 pro 10586
The text was updated successfully, but these errors were encountered: