Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextDocument#isUntitled and non-file-resources #48269

Closed
jrieken opened this issue Apr 20, 2018 · 1 comment
Closed

TextDocument#isUntitled and non-file-resources #48269

jrieken opened this issue Apr 20, 2018 · 1 comment
Assignees
@jrieken
Labels
api feature-request Request for new features or functionality remote Remote system operations issues under-discussion Issue is under discussion for relevance, priority, approach verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2018

Comments

@jrieken
Copy link
Member

jrieken commented Apr 20, 2018

We this API TextDocument#isUntitled and its implementations doesn't check for the untitled-scheme but for the file-scheme. Not entirely sure why that is but my guess is that we have done it for files that can be saved. With the file system provider API this will change and we should revisit this...
@jrieken jrieken self-assigned this Apr 20, 2018
@jrieken jrieken added api under-discussion Issue is under discussion for relevance, priority, approach remote Remote system operations issues labels Apr 20, 2018
jrieken added a commit that referenced this issue Apr 20, 2018
@jrieken
remote, todo update, #48269
9bcb7a0
@jrieken jrieken added this to the April 2018 milestone Apr 25, 2018
jrieken added a commit that referenced this issue Apr 26, 2018
@jrieken
documents with the untitled-scheme are consider untitled, #48269
c73ea16
@jrieken jrieken added the feature-request Request for new features or functionality label Apr 26, 2018
@jrieken
Copy link
Member Author

jrieken commented Apr 26, 2018

This needs to be covered in the release notes because it might be counter-intuitive for some extension authors. Before, document that were not untitled were on disk. With file system providers that isn't true anymore.

@jrieken jrieken closed this as completed Apr 26, 2018
@chrmarti chrmarti added verification-needed Verification of issue is requested verified Verification succeeded labels Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
api feature-request Request for new features or functionality remote Remote system operations issues under-discussion Issue is under discussion for relevance, priority, approach verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@jrieken @chrmarti