Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smoketest: Terminal suite fails #48396

Closed
joaomoreno opened this issue Apr 23, 2018 · 5 comments
Closed

Smoketest: Terminal suite fails #48396

joaomoreno opened this issue Apr 23, 2018 · 5 comments
Assignees
@joaomoreno @Tyriar
Labels
debt Code quality issues smoke-test-failure terminal Integrated terminal issues
Milestone
May 2018

Comments

@joaomoreno
Copy link
Member

https://monacotools.visualstudio.com/Monaco/_build/index?context=allDefinitions&path=%5C&definitionId=106&_a=history

2018-04-23T11:09:19.8955860Z   1) Test Terminal opens terminal, runs 'echo' and verifies the output:
2018-04-23T11:09:19.8981810Z      Error: timeout of 20000ms exceeded. Ensure the done() callback is being called in this test.
@joaomoreno joaomoreno added this to the April 2018 milestone Apr 23, 2018
@jrieken
Copy link
Member

jrieken commented Apr 23, 2018

@Tyriar FYI i have disabled the terminal smoke test to get a green build: 21700be

@Tyriar Tyriar modified the milestones: April 2018, May 2018 Apr 23, 2018
@joaomoreno joaomoreno mentioned this issue Apr 26, 2018
Closed
@Tyriar
Copy link
Member

Tyriar commented Apr 30, 2018

This actually caught a pretty nasty bug early, terminal layout/dimensions are quite broken. Luckily it only affects the dev build, not sure why just yet. Investigating...

@Tyriar
Copy link
Member

Tyriar commented Apr 30, 2018

Ok apparently that's unrelated to the failure.

@joaomoreno it's failing on this line:

https://github.com/Microsoft/vscode/blob/a32ca17c385fbe2af3bf6da44578364d8b0d833b/test/smoke/src/vscode/code.ts#L245

I'm not sure how to debug further or why it would be failing here. XTERM_TEXTAREA appears to be there as await this.code.waitForActiveElement(XTERM_TEXTAREA) succeeds.

@Tyriar Tyriar added debt Code quality issues terminal Integrated terminal issues labels Apr 30, 2018
@joaomoreno
Copy link
Member Author

joaomoreno commented May 2, 2018 •
edited

@Tyriar Yup it seems to be failing there. Btw, you can use --verbose when running yarn smoketest, it will print the raw commands send to Code. In this case, it will repeatedly show the paste command and not succeeding:

** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400
** paste div[id="workbench.panel.terminal"] .terminal-wrapper textarea.xterm-helper-textarea echo 1525255432400

I've also just pushed a change which will also make --verbose open the dev tools of any open workbench window, so we can console.log from the renderer and see the output, while the smoke test runs. 👍

Anyway, the issue is that new DataTransfer() doesn't work anymore... hummm... my bad!

https://github.com/Microsoft/vscode/blob/2d15717a661e48e1c98b993e6a0c7b8df3a85d39/src/vs/platform/driver/electron-browser/driver.ts#L117

image

@Tyriar, I've replaced that with using XTerm's send() API, does it make sense?

fe49af2#diff-f18503c5bde2f9a5aba4b56afd2ef95aR188

@Tyriar
Copy link
Member

Tyriar commented May 14, 2018

@joaomoreno yeah that works 👍, thanks for fixing this 😃

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 16, 2018
lemanschik pushed a commit to code-oss-dev/code that referenced this issue Nov 25, 2022
@joaomoreno
fix terminal smoketests
033f478 
fixes microsoft#48396
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@Tyriar Tyriar

Labels
debt Code quality issues smoke-test-failure terminal Integrated terminal issues
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @Tyriar