Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolHandler API: doesn't work if Code isn't running yet #48479

Closed
joaomoreno opened this issue Apr 24, 2018 · 4 comments
Closed

ProtocolHandler API: doesn't work if Code isn't running yet #48479

joaomoreno opened this issue Apr 24, 2018 · 4 comments
Assignees
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@joaomoreno
Copy link
Member

Testing #48427

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug api labels Apr 24, 2018
@joaomoreno joaomoreno added this to the April 2018 milestone Apr 24, 2018
@joaomoreno joaomoreno self-assigned this Apr 24, 2018
@weinand
Copy link
Contributor

weinand commented Apr 24, 2018

@joaomoreno on macOS running the following from a terminal
open vscode-insiders://andreweinand.protocol-handler/foo
opens VS Code and shows the redirecting alert.
But after pressing "Yes" the handler isn't called because VS Code was launched without the --enable-proposed-api flag.

@joaomoreno
Copy link
Member Author

Interesting, I didn't see it happening for me. I'll investigate more...

@sbatten
Copy link
Member

sbatten commented Apr 24, 2018

Same behavior on Windows for me

@joaomoreno
Copy link
Member Author

joaomoreno commented Apr 26, 2018

This was a cute issue. The protocol handler would register while the user was being prompted whether he wants to let the extension handle the URI. It would then get lost after confirmation.

Steps:

  1. Run code-insiders --open-url vscode-insiders://vscode.git/clone?url=git%40github.com%3AMicrosoft%2Fvscode-vsce.git

You should be prompted as to whether you'd want to let the git extension handle the URL. If accepted, the clone action should take place.

@chrmarti chrmarti added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants