Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in user launch configuration not picked up by debug dropdown #48487

Closed
isidorn opened this issue Apr 24, 2018 · 8 comments
Closed

Changes in user launch configuration not picked up by debug dropdown #48487

isidorn opened this issue Apr 24, 2018 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded

Comments

@isidorn
Copy link
Contributor

isidorn commented Apr 24, 2018

Refs: #48423

Not sure if this was caused by refactoring so assigning to both of us.

  1. Have a launch configuration in your user settings
  2. Rename that launch configuration -> notice how the select drop down name is not updating
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Apr 24, 2018
@isidorn isidorn added this to the April 2018 milestone Apr 24, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Apr 24, 2018

I plan to investigate after I am done testing, so I can first look into it.

@weinand
Copy link
Contributor

weinand commented Apr 24, 2018

I'm pretty sure that I didn't touch anything in that area.

@weinand
Copy link
Contributor

weinand commented Apr 25, 2018

I'm stilling seeing the issue (on macOS and windows)

@weinand weinand reopened this Apr 25, 2018
@weinand weinand added the verification-found Issue verification failed label Apr 25, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Apr 25, 2018

I can reproduce this and the issue seems to be that I am not getting onDidChangeConfiguration from @sandy081 thus forwarding the issue to him.

Additional data:

  1. If I change any other user setting I nicely get the event
  2. Only if I change things inside the launch section in user settings I am not getting an event

I believe this was working 2 days ago, might it be that you changed something in the meantime?

@isidorn isidorn assigned sandy081 and unassigned isidorn Apr 25, 2018
@isidorn isidorn removed this from the April 2018 milestone Apr 25, 2018
@sandy081
Copy link
Member

@isidorn I have not touched anything in this area this week. But assigning to April for investigation to check if something got broken.

@sandy081 sandy081 added this to the April 2018 milestone Apr 25, 2018
@sandy081
Copy link
Member

This was not working from the time fine grained configuration change events were introduced (atleast couple of milestones). Root cause is how settings are merged. We merge object types and replace the rest. Since configuration is of type array value get replaced and reports no effective change. Actually, different version of this problem has been there from the time user launches are introduced. Because ConfigurationService.getValue('launch') is never returning user launches as they are getting removed during merge. They are seen only when ConfigurationService.inspect is called.

@isidorn Not sure how important is to fix it in the end game week, I think the fix would be not trivial.

@sandy081 sandy081 added config VS Code configuration, set up issues and removed verification-found Issue verification failed labels Apr 26, 2018
@sandy081 sandy081 modified the milestones: April 2018, May 2018 Apr 26, 2018
@sandy081
Copy link
Member

Moving this as it is not important to fix.

@sandy081 sandy081 modified the milestones: May 2018, Backlog May 28, 2018
@sandy081
Copy link
Member

This is fixed now.

@sandy081 sandy081 modified the milestones: Backlog, September 2018 Sep 19, 2018
@isidorn isidorn added the verified Verification succeeded label Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants