Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decorations not showing up for second root folder #48502

Closed
bpasero opened this issue Apr 24, 2018 · 7 comments
Closed

Decorations not showing up for second root folder #48502

bpasero opened this issue Apr 24, 2018 · 7 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug file-decorations git GIT issues verified Verification succeeded
Milestone
April 2018

Comments

@bpasero
Copy link
Member

bpasero commented Apr 24, 2018 •
edited

Steps to Reproduce:

  1. generate 2 extension samples via yo code (one typescript, one javascript, leave defaults)
  2. open the first folder
  3. drag and drop the second folder in to produce an untitled workspace
  4. save it

=> for me the decorations for untracked files only ever show up for the first root folder, not the second:

image
@jrieken
Copy link
Member

jrieken commented Apr 24, 2018

@bpasero What kind of decorations are used for the second folder?

@jrieken jrieken added info-needed Issue requires more information from poster file-decorations labels Apr 24, 2018
@bpasero
Copy link
Member Author

bpasero commented Apr 24, 2018 •
edited

@jrieken looks like this is only an issue for the top level files of the workspace folder. The subfolders seem to include the decorations properly:

image

It actually seems like the decorations are there initially and then removed:

flicker_chrome58

Also happens when reordering folders.

@jrieken jrieken added this to the April 2018 milestone Apr 24, 2018
@jrieken jrieken added git GIT issues and removed info-needed Issue requires more information from poster labels Apr 24, 2018
@jrieken
Copy link
Member

jrieken commented Apr 24, 2018

I can repro with a single, new repro. This is the event trace

event vscode.git FLUSH ALL
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/.gitignore
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/launch.json
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/settings.json
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/tasks.json
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscodeignore
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/CHANGELOG.md
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/README.md
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/package.json
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/src/extension.ts
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/test/extension.test.ts
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/test/index.ts
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/tsconfig.json
decorationsService.js:222 event vscode.git file:///Users/jrieken/Code/_samples/foofold/vsc-extension-quickstart.md
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.gitignore U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/launch.json U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/settings.json U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/tasks.json U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscodeignore U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/CHANGELOG.md U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/README.md U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/package.json U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/src/extension.ts U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/test/extension.test.ts U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/test/index.ts U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/tsconfig.json U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/vsc-extension-quickstart.md U
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/vsc-extension-quickstart.md <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/tsconfig.json <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/README.md <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/package.json <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/CHANGELOG.md <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscodeignore <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.gitignore <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/test <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/src <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/out null
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/node_modules null
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/vsc-extension-quickstart.md <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/tsconfig.json <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/README.md <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/package.json <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/CHANGELOG.md <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscodeignore <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.gitignore <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/test <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/src <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/out <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/node_modules <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode <empty>
decorationsService.js:278 data Explorer file:///Users/jrieken/Code/_samples/foofold/.vscode/launch.json <empty>
decorationsService.js:278 data Problems file:///Users/jrieken/Code/_samples/foofold/.vscode/launch.json <empty>
decorationsService.js:278 data Explorer file:///Users/jrieken/Code/_samples/foofold/.vscode/settings.json <empty>
decorationsService.js:278 data Problems file:///Users/jrieken/Code/_samples/foofold/.vscode/settings.json <empty>
decorationsService.js:278 data Explorer file:///Users/jrieken/Code/_samples/foofold/.vscode/tasks.json <empty>
decorationsService.js:278 data Problems file:///Users/jrieken/Code/_samples/foofold/.vscode/tasks.json <empty>
decorationsService.js:278 data Explorer file:///Users/jrieken/Code/_samples/foofold/src/extension.ts <empty>
decorationsService.js:278 data Problems file:///Users/jrieken/Code/_samples/foofold/src/extension.ts <empty>
decorationsService.js:278 data Explorer file:///Users/jrieken/Code/_samples/foofold/test/extension.test.ts <empty>
decorationsService.js:278 data Problems file:///Users/jrieken/Code/_samples/foofold/test/extension.test.ts <empty>
decorationsService.js:278 data Explorer file:///Users/jrieken/Code/_samples/foofold/test/index.ts <empty>
decorationsService.js:278 data Problems file:///Users/jrieken/Code/_samples/foofold/test/index.ts <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/launch.json <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/settings.json <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/.vscode/tasks.json <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/src/extension.ts <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/test/extension.test.ts <empty>
decorationsService.js:278 data vscode.git file:///Users/jrieken/Code/_samples/foofold/test/index.ts <empty>

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Apr 24, 2018
@joaomoreno
Copy link
Member

@jrieken Git has two decoration providers: status and ignored. Status comes first, everything is OK. Ignored comes second, and returns undefined for all non-ignored files. That undefined seems to overwrite the initial status decoration. I thought they'd get merged?

@jrieken
Copy link
Member

jrieken commented Apr 24, 2018

Ah, bad logging... Yeah, they should be getting merged (despite them having the same name)...

@bpasero
Copy link
Member Author

bpasero commented Apr 26, 2018 •
edited

Something is still weird. The original issue seems to be gone but I see this one still:

  • start with one hello world extension and notice the .vscode folder showing with a decoration (green dot)
  • add a second folder (this enters multi root) and notice how that decoration goes away for that folder for the first root

before

@bpasero bpasero reopened this Apr 26, 2018
@bpasero bpasero added the verification-found Issue verification failed label Apr 26, 2018
@joaomoreno joaomoreno removed their assignment Apr 26, 2018
@jrieken
Copy link
Member

jrieken commented Apr 26, 2018

Yeah, different issue and I'd say unrelated to what I have fixed yesterday

@jrieken jrieken mentioned this issue Apr 26, 2018
Closed
@jrieken jrieken closed this as completed Apr 26, 2018
@jrieken jrieken removed the verification-found Issue verification failed label Apr 26, 2018
@bpasero bpasero added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug file-decorations git GIT issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @jrieken