Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal API: split terminal not showing up #48510

Closed
bpasero opened this issue Apr 24, 2018 · 1 comment
Closed

Terminal API: split terminal not showing up #48510

bpasero opened this issue Apr 24, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Apr 24, 2018

Refs: #48434

It looks like when you split a terminal, the second terminal is not showing up in the new API for accessing terminals.

Extension Code:

'use strict';
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {

    console.log('Congratulations, your extension "end-ts" is now active!');

    let disposable = vscode.commands.registerCommand('extension.sayHello', () => {
        vscode.window.showInformationMessage('Hello World!');

        console.log("Terminals: " + vscode.window.terminals.length);

        vscode.window.onDidOpenTerminal(e => {
            console.log("Terminal opened. Total count: " + vscode.window.terminals.length);

            e.onData(data => {
                console.log("Terminal data: ", data);
            });
        });
    });

    context.subscriptions.push(disposable);
}

export function deactivate() {
}

Start with one terminal and split it. Only the first shows data when you type.

@Tyriar
Copy link
Member

Tyriar commented Apr 25, 2018

Good catch!

@Tyriar Tyriar closed this as completed Apr 25, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues labels Apr 25, 2018
@Tyriar Tyriar added this to the April 2018 milestone Apr 25, 2018
Tyriar added a commit that referenced this issue Apr 25, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants